Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected tools to the main log.info section #162

Open
sorelfitzgibbon opened this issue Feb 13, 2024 · 1 comment
Open

Add selected tools to the main log.info section #162

sorelfitzgibbon opened this issue Feb 13, 2024 · 1 comment

Comments

@sorelfitzgibbon
Copy link
Contributor

The main log currently has a section:

Tools Used:
    uclahs-cds/pipeline-convert-BAM2FASTQ: 2.0.0-rc.1
    uclahs-cds/pipeline-align-DNA: 9.0.0
    uclahs-cds/pipeline-recalibrate-BAM: 1.0.0-rc.4
    uclahs-cds/pipeline-call-gSNP: 10.0.0-rc.3
    uclahs-cds/pipeline-call-sSNV: 8.0.0-rc.1
    uclahs-cds/pipeline-call-mtSNV: 3.0.0
    uclahs-cds/pipeline-call-gSV: 4.0.1
    uclahs-cds/pipeline-call-sSV: 6.0.0-rc.1

which lists all tools regardless of which tools were selected to be run. This seems confusing. I suggest either limiting this list to the tools actually selected (preferred) or changing the title to something like Tool Versions, and adding a selected tools section.

@yashpatel6
Copy link
Collaborator

I lean towards the latter to make sure all versions, regardless of usage, are captured in the log. It makes sense to add an indicator or a separate section to show which pipelines are actually enabled (relatively easy to do since each pipeline-specific params will contain an indicator of whether it's enabled or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants