Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player accessibility improvements. #2

Open
FrenjaminBanklin opened this issue Jul 27, 2023 · 0 comments · May be fixed by #3
Open

Player accessibility improvements. #2

FrenjaminBanklin opened this issue Jul 27, 2023 · 0 comments · May be fixed by #3

Comments

@FrenjaminBanklin
Copy link
Contributor

FrenjaminBanklin commented Jul 27, 2023

This list may grow as more issues are discovered.

  • The widget's welcome screen can only be dismissed by clicking on it.

    • This is easy enough to fix by also adding a keypress event listener to the welcome screen.
  • The submit and reset buttons do not visually indicate when they have focus.

    • This is a one-line CSS change to apply the same rules on focus that are applied on hover.
  • The submit and reset buttons are not reachable in the tab order.

    • Changing these buttons to submit/reset inputs and their parent element to a form solves the reachability problem and probably makes more sense to screen readers semantically. Existing event listeners need to be adjusted a bit to account for the buttons becoming inputs and to prevent default form behaviors.
  • The submit confirmation buttons when not all blanks have been filled in aren't reachable in the tab order.

    • This can be fixed by giving these buttons tab indices and toggling inert on the relevant parts of the game depending on user interactions. These buttons also need keyup event handlers since they currently only react to clicks. As a bonus, the 'What am I missing?' button could probably auto-focus the first empty blank as a convenience feature.
FrenjaminBanklin added a commit to FrenjaminBanklin/word-guess-materia-widget that referenced this issue Jul 27, 2023
…s. Replaced submit/reset buttons and main game area with a form. Added keyup event listeners where relevant. Adjusted ARIA labeling on several components. Added corresponding focus rules to buttons with hover rules. Added logic to toggle inert on and off depending on open dialogs. Added auto-focus logic when canceling a submission to fill more blanks.
@FrenjaminBanklin FrenjaminBanklin linked a pull request Jul 27, 2023 that will close this issue
FrenjaminBanklin added a commit to FrenjaminBanklin/word-guess-materia-widget that referenced this issue Jul 27, 2023
FrenjaminBanklin added a commit to FrenjaminBanklin/word-guess-materia-widget that referenced this issue Jul 27, 2023
FrenjaminBanklin added a commit to FrenjaminBanklin/word-guess-materia-widget that referenced this issue Jul 28, 2023
…sted spacing of the widget title. Changed keybinds from Ctrl+W and Ctrl+T to Ctrl+Enter and Ctrl+Space. Removed the 'read current blank's sentence' function since at the moment it doesn't seem reasonably possible to accomplish without being highly error prone. Rearranged a few elements and replaced keyup event listeners with keypress event listeners to prevent accidental submissions. Added a keybind to re-read keyboard instructions.
FrenjaminBanklin added a commit to FrenjaminBanklin/word-guess-materia-widget that referenced this issue Jul 31, 2023
…orrect key for reading out the entire paragraph. Adjusted the control+Enter listener's behavior to dynamically build the entire paragraph and substitute the current input values where applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant