Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Move shared constants to default config file. #790

Closed
0xcodercrane opened this issue Sep 21, 2023 · 14 comments · Fixed by #847
Closed

Move shared constants to default config file. #790

0xcodercrane opened this issue Sep 21, 2023 · 14 comments · Fixed by #847

Comments

@0xcodercrane
Copy link
Contributor

          @0xcodercrane shouldn't these all be moved to `ubiquibot-config-default.ts` ? If so, please file a new issue or just handle it. Thanks!

Originally posted by @pavlovcik in #748 (comment)

@molecula451
Copy link
Member

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 22, 2023

Deadline Fri, 22 Sep 2023 06:32:10 UTC
Registered Wallet 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @molecula451
    Copy link
    Member

    so it's shared.ts being deprecated/purged? @0xcodercrane

    @molecula451
    Copy link
    Member

    Should we get rid of

    export const DEFAULT_NETWORK_ID = 1; // ethereum

    as there is an:

    ??

    @molecula451
    Copy link
    Member

    development seems broken, can't PR till it's fixed

    @0x4007
    Copy link
    Member

    0x4007 commented Sep 23, 2023

    You can certainly pr and rebase when it's fixed.

    @molecula451
    Copy link
    Member

    You can certainly pr and rebase when it's fixed.

    #802

    @0x4007
    Copy link
    Member

    0x4007 commented Sep 23, 2023

    Should we get rid of

    export const DEFAULT_NETWORK_ID = 1; // ethereum

    as there is an:

    ??

    Default I feel like it should be on Mainnet. Seems quite opinionated for us to default to a sidechain.

    @molecula451
    Copy link
    Member

    Should we get rid of

    export const DEFAULT_NETWORK_ID = 1; // ethereum

    as there is an:

    ??

    Default I feel like it should be on Mainnet. Seems quite opinionated for us to default to a sidechain.

    and to your suprise, this constant it's not being used anywhere in the code, no but there is other code that it's being responsible for the rpc

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 29, 2023

    Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Sat Sep 23 2023 19:19:58 GMT+0000 (Coordinated Universal Time)

    1 similar comment
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 29, 2023

    Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Sat Sep 23 2023 19:19:58 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 2, 2023

    Task Assignee Reward

    [ CLAIM 18.75 WXDAI ]

    0x4D0704f40...BD826dCFc4

    If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
    We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 2, 2023

    Task Creator Reward

    0xcodercrane: [ CLAIM 17.4 WXDAI ]

    @molecula451
    Copy link
    Member

    it would be nice to get back commentary rewards @0xcodercrane

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    3 participants