Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Permit generation skipped because the issue was not closed as completed #503

Closed
0x4007 opened this issue Jul 13, 2023 · 13 comments · Fixed by #733
Closed

Permit generation skipped because the issue was not closed as completed #503

0x4007 opened this issue Jul 13, 2023 · 13 comments · Fixed by #733

Comments

@0x4007
Copy link
Member

0x4007 commented Jul 13, 2023

Let's reword this to

Permit generation skipped because this is marked as unplanned.

Permit generation skipped because the issue was not closed as completed

Originally posted by @ubiquibot in ubiquity/pay.ubq.fi#48 (comment)

@BeanieMen
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 7, 2023

Deadline Thu, 07 Sep 2023 13:20:17 UTC
Registered Wallet 0x5387ab162D3Fc48a8c9857517E36cF4B55dE8c1a
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 10, 2023

    Task Assignee Reward

    [ CLAIM 18.75 WXDAI ]

    0x5387ab162...4B55dE8c1a

    If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
    We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

    @ubiquity ubiquity deleted a comment from ubiquibot bot Sep 10, 2023
    @0x4007 0x4007 reopened this Sep 10, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 10, 2023

    @me505 please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 18.75 WXDAI will be deducted from your next bounty.

    @0x4007 0x4007 closed this as completed Sep 10, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 10, 2023

    Task Creator Reward

    pavlovcik: [ CLAIM 16 WXDAI ]

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 10, 2023

    Conversation Rewards

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 10, 2023

    Task Creator Reward

    pavlovcik: [ CLAIM 16 WXDAI ]

    This seems too high. I believe it is crediting the italicized text but I just removed credit for italics.

    https://github.com/ubiquity/ubiquibot-config/blob/development/.github/ubiquibot-config.yml

    @whilefoo rfc

    It should be $5.2 based on the word count, with a 4x issue creator multiplier.

    The italics and anchor inside the italics should not be credited for. Can you fix this?

    @whilefoo
    Copy link
    Collaborator

    If I understand correctly the text inside italics (and anchor) should not be credited only when config is i: 0 or even if italics have reward?

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 12, 2023

    Yes that's correct. The default config should have rewards disabled for every element. The organization must manually enable support for italicized text if they want it.

    For whatever its worth, when I was reading the mdast documentation, it considered bold and italics the same element.

    @whilefoo
    Copy link
    Collaborator

    Ok so this behavior should be for all elements, if an element has reward 0 then it should not count the text inside. Because currently even if all elements have 0 reward and word reward is 1 it will credit every word.

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 14, 2023

    Ok so this behavior should be for all elements, if an element has reward 0 then it should not count the text inside. Because currently even if all elements have 0 reward and word reward is 1 it will credit every word.

    Interesting problem. I imagine that we need some type of special value to instruct to the parser to exclude it from the calculation entirely. Perhaps we can use null or even ignore?

    For example:

    ul: 0
    li: 0.5
    i: ignore
    
    - this is a _test_
    

    Would yield 0.5 + ( 0.1 * 3 ) = 0.8, ignoring "test"

    @whilefoo
    Copy link
    Collaborator

    That might be a little bit awkward for partners because default config will be ignore so if they want to count the words inside paragraphs they have to explicitly set p: 0. Unless we make some sensible defaults.

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 14, 2023

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    3 participants