-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rpc-handler
and fix tests following beta merge
#345
Merged
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e1fad5e
feat: bump rpc-handler
Keyrxng 7d6043d
chore: remove networkId param from render-ens-name
Keyrxng 504b7e5
chore: export NetworkId convert util
Keyrxng 4aa8195
chore: use getters from rpc-handler for adding new network
Keyrxng a63df44
chore: add localhost default anvil
Keyrxng eca8322
chore: use getters in appState
Keyrxng 6b6dd4c
chore: consolidate rpc-handler import
Keyrxng f2ccbe6
chore: fix view claim onclick
Keyrxng 4931e58
chore: return the original anvil spawner
Keyrxng ba2a65d
fix: reset view claim on pagination
Keyrxng be25449
chore: comment and no need to throw error on fail to store permit
Keyrxng 70c6f83
chore: use and fix button visibilty for reset after view claim
Keyrxng 2dd7efd
chore: multi permit fn, max seems to be around 3 or 4
Keyrxng 0f43b4b
chore: use gnosis id for anvil fork
Keyrxng 43c9de4
chore: success and failure tests
Keyrxng 7b4301f
chore: gift card tests
Keyrxng ee55943
Merge remote-tracking branch 'upstream/development' into development
Keyrxng 4eb4ce9
chore: fix last card test
Keyrxng 0a86f01
chore: separate funding step
Keyrxng 593b9d8
chore: yarn start on cypress action
Keyrxng 379d6c1
chore: use wrangler build as cypress wf start cmd
Keyrxng 682977a
chore: remove duplicate step
Keyrxng c7c04f1
chore: use hardcoded permit url
Keyrxng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ commit.txt | |
.pnp.cjs | ||
.pnp.loader.mjs | ||
.env | ||
.dev.vars | ||
static/dist | ||
static/bundles | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EresDev you had this as it's own step before but that's not right as the env hadn't fully setup yet that's why I've made this change here.
Is this the correct way to pass reloadly env vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ubq-testing/pay.ubq.fi/actions/runs/11504344113/job/32023622908#step:7:1
I just added the id and secret for the sandbox taken directly from the google doc to my repo secrets and the errors are still present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is logic missing inside the cards feature that is not throwing the error properly otherwise Cypress would fail, do you agree?
The log style looks unfamiliar to me also so I'm not 100% where it's coming from, so I think it needs it's own task and shouldn't block this pr.