Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call decimals() on generating test permits #249

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: call decimals() on generating test permits #249

merged 1 commit into from
Jun 13, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Jun 12, 2024

I've been trying to generate permits for USDT with 6 decimals which ended up converting to a wrong number.

This PR takes into account token decimals when generating test permits.

@rndquu rndquu requested a review from Keyrxng as a code owner June 12, 2024 11:21
@rndquu rndquu changed the title fix: call decimals() on generation test permits fix: call decimals() on generating test permits Jun 12, 2024
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 12, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Preview Deployment
ac98c88e21ef8d0525e60656917ad76562f244de

Keyrxng
Keyrxng approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@Keyrxng Keyrxng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine so long as the RPC_PROVIDER_URL is set correctly i.e if localhost anvil should be running first otherwise we get a no network error.

I'll add a comment to the readme in #246

@rndquu rndquu merged commit 8b1c07d into ubiquity:development Jun 13, 2024
4 checks passed
@rndquu rndquu deleted the fix/test-permit-decimals branch June 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keyrxng Keyrxng Keyrxng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndquu @Keyrxng