fix: readme #246
Merged
fix: readme #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Jun 11, 2024
0x4007
reviewed
Jun 11, 2024
0x4007
reviewed
Jun 11, 2024
I will keep this in mind in the future, that readme you attached is a lot cleaner and direct. Should we use it in place of the suggestions you have made to my written version? I have also had GPT4o rewrite it and had it keep the expected behaviour but tighten it up, I think I'd use it over my version as-is but I'm not 100% on what to do. |
|
https://github.com/ubiquity/pay.ubq.fi/actions/runs/9472156534/job/26097027405?pr=246 That's an interesting CI error |
|
You can use any ChatGPT 4o processed version in place of your submission. Don't need to worry about my suggestions. |
rndquu
approved these changes
Jun 14, 2024
0x4007
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #244
How relevant is everything underneath
# How to test locally? I think it could be all be removed. There is auto-deploy for previews etc now so Cloudflare and hosting is irrelevant.I think remove everything below and write a simplified walk through of the paths the UI can take and what is expected from things and when the amazon cards are released they can have their own section.