Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offramp link to docs #240

Merged
merged 19 commits into from
Jul 13, 2024
Merged

Offramp link to docs #240

merged 19 commits into from
Jul 13, 2024

Conversation

jordan-ae
Copy link
Contributor

@jordan-ae jordan-ae commented Jun 5, 2024

Resolves #239

Screen Shot 2024-06-19 at 11 51 27

Screenshot 2024-06-19 115213

@jordan-ae jordan-ae requested a review from rndquu as a code owner June 5, 2024 02:14
static/index.html Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
@rndquu rndquu marked this pull request as draft June 6, 2024 07:25
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 6, 2024

@jordan-ae jordan-ae marked this pull request as ready for review June 6, 2024 09:38
@jordan-ae jordan-ae requested a review from Keyrxng as a code owner June 6, 2024 09:38
@jordan-ae jordan-ae requested a review from 0x4007 June 6, 2024 09:38
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to test that your deliverables work before you ask for reviews. It's not a link. It doesn't work.

@jordan-ae
Copy link
Contributor Author

You need to test that your deliverables work before you ask for reviews. It's not a link. It doesn't work.

Sorry about that my bad. I Assumed it was going to link and rushed through it. So sorry

@Keyrxng
Copy link
Member

Keyrxng commented Jun 9, 2024

The notifications are misaligned which should not happen these should remain centred

image

@jordan-ae
Copy link
Contributor Author

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

@Keyrxng
Copy link
Member

Keyrxng commented Jun 9, 2024

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

static/index.html Outdated Show resolved Hide resolved
@@ -182,7 +182,7 @@
<div id="build">
<a target="_blank" rel="noopener noreferrer"></a>
</div>
<div class="faq-icon" href="https://github.com/ubiquity/work.ubq.fi/discussions/53" target="_blank">
<div class="faq-icon" onclick="window.open('https://github.com/ubiquity/work.ubq.fi/discussions/53', '_blank')">
Copy link
Member

@Keyrxng Keyrxng Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap the div in an <a> instead of this

edit: why are you using this approach, is there a specific reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I did this just because I was wrapping it with a div and you can href on a div

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think using a proper anchor tag and then wrapping the svg in a div to style it like @0x4007 suggested is the way to go.

It's not a huge SEO factor in this case but it's a better practice to use <a> where applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks. Corrected to reflect this. I thought @0x4007 meant to get rid of the <a> and wrap it just with a <div>. My bad!

@Keyrxng
Copy link
Member

Keyrxng commented Jun 9, 2024

lmao I've been adding comments and seeing PENDING thinking that means that the changes to be made are pending.

I realise my mistake now, @jordan-ae can you see my comments? 😂

@jordan-ae
Copy link
Contributor Author

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

I have wrapped the div but the alignment doesn't break. Any steps to repro this?

@Keyrxng
Copy link
Member

Keyrxng commented Jun 9, 2024

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

I have wrapped the div but the alignment doesn't break. Any steps to repro this?

other than an unstyled <a> not that I know of, if you can't repro that's probs a good thing.

Copy link
Member

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Unable to repro misaligned notifications now. That may have been my own error my mistake @jordan-ae.

remember to hit "resolve conversation" if you have implemented the change appropriately and there are no open questions to/from the reviewer for that request.

@0x4007
Copy link
Member

0x4007 commented Jun 10, 2024

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

@jordan-ae
Copy link
Contributor Author

jordan-ae commented Jun 11, 2024

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

Fixed it the styles now match the build

@rndquu
Copy link
Member

rndquu commented Jun 14, 2024

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

Fixed it the styles now match the build

@jordan-ae As far as I understand the commit hash should be horizontally aligned with the question sign, right now they're not on the same level, pls fix

Screenshot 2024-06-14 at 18 44 34

@rndquu rndquu marked this pull request as draft June 14, 2024 15:48
@jordan-ae jordan-ae marked this pull request as ready for review June 18, 2024 21:28
@Keyrxng
Copy link
Member

Keyrxng commented Jun 18, 2024

Looks aligned when I pull locally on both mobile and desktop, notifications don't appear to be out of alignment either.

@jordan-ae for future aesthetic changes it would be nice if you could show a video of mobile and desktop or a screenshot of both., I would appreciate it and I try to do the same in my PRs

Copy link
Member

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jordan-ae

Edit:

Just saw CI is failing, let's get that resolved

They are passing locally, so how about I fix CI in another pull? hold tight

@jordan-ae
Copy link
Contributor Author

Just saw CI is failing, let's get that resolved

They are passing locally, so how about I fix CI in another pull? hold tight

They are working locally too for me. Maybe we can re-run the workflow to rule out the possibility of an inconsistency happening during runtime

@Keyrxng
Copy link
Member

Keyrxng commented Jul 1, 2024

@jordan-ae could you merge jordan-ae#1 please

@Keyrxng
Copy link
Member

Keyrxng commented Jul 1, 2024

@jordan-ae can you resolve the conflict please and we can get this merged.

my ci run passed so we should be good to go

@Keyrxng Keyrxng self-requested a review July 1, 2024 12:17
cypress/e2e/claim-portal-success.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/claim-portal-success.cy.ts Outdated Show resolved Hide resolved
jordan-ae and others added 2 commits July 1, 2024 13:32
Co-authored-by: Keyrxng <106303466+Keyrxng@users.noreply.github.com>
Co-authored-by: Keyrxng <106303466+Keyrxng@users.noreply.github.com>
@Keyrxng
Copy link
Member

Keyrxng commented Jul 1, 2024

@0x4007 I think this could be merged now if you are also happy with these changes

@jordan-ae jordan-ae requested review from rndquu and Keyrxng July 5, 2024 09:05
@jordan-ae jordan-ae requested a review from Keyrxng July 11, 2024 10:43
@jordan-ae
Copy link
Contributor Author

@0x4007 i think this is ready to be merged. Please 🙏

@Keyrxng
Copy link
Member

Keyrxng commented Jul 12, 2024

@rndquu can you review please, I believe the thumbs up is an implicit ok for merge

@0x4007
Copy link
Member

0x4007 commented Jul 13, 2024

Actually @Keyrxng you're the last say on this repo

@Keyrxng Keyrxng merged commit 43defa8 into ubiquity:development Jul 13, 2024
4 checks passed
@ubiquibot ubiquibot bot mentioned this pull request Jul 13, 2024
@Keyrxng
Copy link
Member

Keyrxng commented Jul 13, 2024

Actually @Keyrxng you're the last say on this repo

My mistake, slight misunderstanding of things @0x4007

Going forward, PRs need at least one other approval and cosmetic changes should be run by you at least once before merging?

@0x4007
Copy link
Member

0x4007 commented Jul 13, 2024

Yeah I definitely want direct say in cosmetics. Thanks.

Also the other approvals aren't explicitly required but it's generally a good idea to get more approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offramp Link to Docs
4 participants