E2E tests for payment portal #225
Conversation
|
@gentlementlegen I'd appreciate any comments on how to improve these I kept the code base changes to a minimum for two reasons:
Perhaps it's because I'm wet behind the ears still but it's pretty difficult to handle MM interactions from start to finish, I just stubbed the global for it and made it work that way but maybe there's a better way for handling it? I'll also add that in using Anvil because you do not need explicit permission if you are using one of the default accounts, transactions can be fired to Anvil while the UI represents a failed tx state. I had tried using two instances set to different ports one would be the When I run cypress GUI, I have no extensions installed which I assume is how it should be tested. |
There was a problem hiding this comment.
@Keyrxng Thank you for the tests. I tried to run them locally but 2/3 failed. Could you link the latest successful run to this PR?
|
All tests pass for me which is curious. Can I ask which two failed so I can try to debug env related issues?
I'll add the workflow I overlooked that
|
|
I do not know now if that is related to my |
|
Appreciated mate.
I see the balance is N/A meaning that anvil hasn't been setup, did you do:
in three separate terminals? If not that is the problem, if you did then something else is amiss I'll need to try debug. Very rarely anvil will fail to connect to the fork_url rpc endpoint. Wait you must have done if the others passed right? I'm a bit confused with this atm but I'll try my best with it on my end to reproduce |
|
ready when you are @gentlementlegen |
|
If this could be merged in today that would be amazing cheers team @0x4007 @gentlementlegen, I'm only pushing for it because it's 99.98% ready |
Resolves #215