-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite load on non-web3 friendly browsers #221
Conversation
I spent a little bit last night trying to hack together a solution for combining our Likely because when using anvil default accounts it either auto-signs tx or it's just not a requirement at all. Either way it fell through so the only viable options for taking over the user's wallet RPC is:
Tried this as well as having the user just sign the tx and fire it on the optimal rpc, lots of different variations but in one way or another it either didn't work as intended or would remove feedback such as the wallet tx confirmation request, etc. Looking into Web3.js it seems possible but also like a step backwards
import { Eip1193Bridge } from "@ethersproject/experimental/retry-provider";
const signer = "... any way you get an ethers Signer...";
const provider = "... any way you get an ethers Provider...";
const eip1193Provider = new Eip1193Provider(signer, provider); |
@gentlementlegen the link doesn't work on pulls it seems |
Hey @Keyrxng thanks for your pull. Apologies for being pedantic but you need to redo your pull and minimize unnecessary changes. I recall mentioning this before. Please keep this in mind for your future pulls. The reason your pulls aren't getting merged is because you make it more difficult to review when you make out of scope changes. The more changes you make, the exponentially slower it is to review, approve, and merge in. This is also compounded by the issue not being a high priority task to close out as well. |
No I appreciate it, it can't be enjoyable to be on the receiving end of it so I'll be sure to keep it in mind |
@0x4007 It seems the After investigation, two main issues: |
@gentlementlegen the simple solution is to hard code a permit made out to ubq.eth We don't need to test the full flow, just test the table rendering for now. |
@Keyrxng Questions:
|
With the toasting of all errors, the tests create error toasts that are caused by the mocking/injection of I tried to find a way to silence them without too much change with little effect. The tests still pass as expected and those toasts can be ignored as they do not block tests and are only present because of the env. If it would be better handled I will make the relevant changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #220
QA: