-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rpc upgrade #204
feat: rpc upgrade #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems mostly fine but there were a lot more changes than I expected around the ENS lookup.
The only reason being is because the UBQ RPCs are offline atm, I'll revert the changes back once those are back online if that's preferred |
static/scripts/rewards/render-transaction/read-claim-data-from-url.ts
Outdated
Show resolved
Hide resolved
No it won't, you are correct we need to see mobile debug logs to see why the tx is failing. The confusion it seems, is that all of the previous RPC issues and PRs have nothing to do with writing a tx on-chain. Allowance and BalanceOf are the only two functions which the 'optimized RPCs' affect. The original need to optimize them came from the UI loading times which were significantly improved between myself and pav addressing CSS and unneeded fetch calls as well as preventing a UI glitch when any failed calls happened |
@Keyrxng Could you:
|
Love to see it! This PR improves the rpc-handler a lot, specifically it being used in other projects. I've broken the PR into two, one for the tests and one for the polymorphic exports. Because it introduces breaking changes via improved type exports it's probably best to update the rpc-handler first. |
https://www.npmjs.com/package/@ubiquity-dao/rpc-handler is updated Now you're free to:
|
I've rerun the tests after each commit without error after updating the RPC endpoint. Could that workflow be run again with debug logging enabled pls |
Are you talking about the Cypress test workflow? |
I was @gentlementlegen, I haven't seen the |
race conditions avoided with a wait step added to the workflow which I'm sure should prevent the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, RPC provider is fetched from https://www.npmjs.com/package/@ubiquity-dao/rpc-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too, please fix conflicts.
good to go |
@Keyrxng Should we close ubiquity/.github#100 as completed? |
great work @Keyrxng |
We could break apart the funding command into distinct steps and have a workflow step for each with a hardcoded wait in between. Or a new script to handle the funding actions separately, waiting between each action and confirming it's affect? Locally Since tests should be infallible I guess a couple error prone points should be taken care of:
|
this is still open and this is the prod staking repo I'm sure so I'll tie this up and then it can be closed |
Relates to ubiquity/.github#100
constant.ts
using my package for sake of dev but once published I'll swap it out