Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network switching bug #285

Closed
Keyrxng opened this issue Aug 21, 2024 · 12 comments
Closed

Network switching bug #285

Keyrxng opened this issue Aug 21, 2024 · 12 comments

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Aug 21, 2024

Requires #274

When attempting to claim a permit from a different network you receive a prompt to change network but you must refresh the page in order to successfully claim it. Once refreshed it goes through fine.

There are error logs regarding underlying network changed and the ethers transaction error.

I'm unsure off the top of my head what the solution for it would be without further debugging.

time: 2-4 hours
@whck6
Copy link

whck6 commented Sep 8, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Sep 8, 2024

DeadlineSun, Sep 8, 8:05 PM UTC
Registered Wallet 0x1133830C73B2251DB9373e1B668D01E9dd2B99B1
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Sep 12, 2024

@whck6, this task has been idle for a while. Please provide an update.

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

@whck6, this task has been idle for a while. Please provide an update.

@Keyrxng looks like you need to handle something related to the pull so this can get merged

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 12, 2024

So the required PR (#274) was merged and reverted because of changes required which seemingly are only minor-mid CSS issues as far as I can gather.

Due to this, either @pbkompasz must add the final tweaks and address the issue and/or they are addressed by someone else before this is merged.

This task PR comes with no QA or anything, it's an assumption at this point whether it would work or not.


I could test it inside #274 I guess but it didn't seem right because if that PR wasn't accepted then this task would be closed as not planned as it's a non-issue until multi-network permits. So I'm not certain how or what to push through at the moment, I feel that it rests on whether #274 is fixed and merged.

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

What does multi permit support have to do with this problem

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 12, 2024

What does multi permit support have to do with this problem

The problem only exists because the single Web3Provider needs to change network without recreating or properly "flushing" the ethers.provider class. It's a non-issue on development because we mint single permits and they are single networked at this point too.

This task aims to resolve an issue directly tied to multi-network permits because it is those that are intermittently unclaimable without a page refresh, development is fine and has no such issues because we operate on one network at any one time.

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

Well we can certainly merge it anyways it doesn't matter what order its merged in. If you need to test you can just pull both in on your own branch and try.

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 12, 2024

Well we can certainly merge it anyways it doesn't matter what order its merged in.

Understood then, I'll review now.

Copy link
Contributor

ubiquity-os bot commented Sep 15, 2024

@whck6, this task has been idle for a while. Please provide an update.

@whck6
Copy link

whck6 commented Sep 16, 2024

/stop

@0x4007
Copy link
Member

0x4007 commented Sep 16, 2024

/stop

I think this capability is broken right now!

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants