Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing scripts #284

Closed
Keyrxng opened this issue Aug 21, 2024 · 9 comments
Closed

Update testing scripts #284

Keyrxng opened this issue Aug 21, 2024 · 9 comments

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Aug 21, 2024

Requires #274

The linked PR introduces support for stacked permits and extends multi-network capabilities.

Proposed changes for streamlined testing:

  • Setup two Anvil instances:

    • One targeting Gnosis (current setup).
    • Another targeting Ethereum.
  • Configuration requirements:

    • The new instance should operate on port 8546 with networkId 31338.
  • Funding script updates:

    • Update the funding script to reflect the "whale" address as the updated "WXDAI" token holder for this network.
    • Set distinct approvals and balances compared to the first instance for clarity.
  • Script adjustments:

    • Eliminate process.env usage and hardcode necessary values to enhance clarity and prevent operational errors during script execution.
  • Permit generation:

    • Generate two permits from the original instance and one from the new instance, to avoid breaking old tests.
  • Additional testing scripts:

    • Introduce test:anvil-eth and test:fund-eth scripts, to be utilized only when testing this feature.
  • RPC Handler Update:

    • Implement a NODE_ENV check in use-rpc-handler to ensure compatibility:
      return new ethers.providers.JsonRpcProvider(
        networkId === 31337 ? "http://localhost:8545" : "http://localhost:8546", networkId
      );
      This ensures the correct provider is returned since 31338 is not a supported network in the rpcHandler package
time: 2 hours
@harshmittal1750
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Oct 27, 2024

! Please set your wallet address with the /wallet command first and try again.

@harshmittal1750
Copy link

/wallet

Copy link
Contributor

ubiquity-os bot commented Oct 27, 2024

- error: missing required argument 'address'

@harshmittal1750
Copy link

/wallet 0x085195Da50B895b5b31C1A2C6264D4a7eB39D6F0

Copy link
Contributor

ubiquity-os bot commented Oct 27, 2024

+ Successfully registered wallet address

@harshmittal1750
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Oct 27, 2024

Warning! This task was created over 66 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Sun, Oct 27, 3:31 PM UTC
Beneficiary 0x085195Da50B895b5b31C1A2C6264D4a7eB39D6F0

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@Keyrxng
Copy link
Member Author

Keyrxng commented Oct 27, 2024

@harshmittal1750 I'm sorry to let you know but it's better that this task be closed as unplanned as the original changes this PR was references were never implemented, sorry about that.

Please feel free to take on another task although if you see this warning:

Warning! | This task was created over 66 days ago. Please confirm that this issue specification is accurate before starting.

please tag myself or someone else from the org and we'll let you know if it's still relevant.

@Keyrxng Keyrxng closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants