Removing permit from URL on mobile only #256
Assignees
Comments
|
@Keyrxng might be an easy one for you |
+ Evaluating results. Please wait... |
![UbiquiBot[dev]](https://avatars.githubusercontent.com/in/257883?s=40&u=1eea9b595c7c8aa1f9dd80751aa25f169024431e&v=4){kind=avatar}
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 25 |
| Review | Comment | 1 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Resolves #256 Manually QA'd desktop and mobile with both working… | 0content:
p:
count: 12
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.5 | - |
[ 8.08 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 7.92 |
| Issue | Comment | 1 | 0.16 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
It seems to get in the way for me when I'm doing the normal flow… | 8.8content:
p:
count: 88
score: 1
wordValue: 0.1
formattingMultiplier: 1
| 0.9 | 7.92 |
@Keyrxng might be an easy one for you | 1.6content:
p:
count: 8
score: 1
wordValue: 0.2
formattingMultiplier: 1
| 0.1 | 0.16 |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 20.8 |
| Issue | Comment | 1 | 1.6 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
It seems to get in the way for me when I'm doing the normal flow... | 20.8 | 1 | 20.8 |
@Keyrxng might be an easy one for you... | 1.6 | 0.21 | 1.6 |
@gentlementlegen relevance needs to be 1 for spec. Also the scoring is so different. Is it the spec multiplier? It doesn't seem to be intervals of each other (my scoring between both versions) so I don't understand. |
|
Scoring equal to one was noted within this issue: ubiquity-os-marketplace/text-conversation-rewards#26 As for the multiplier for the spec I am not sure how v1 counted it because there is no detail. The multipliers are supposedly the same in both versions but the logic might be different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems to get in the way for me when I'm doing the normal flow claiming on my desktop for when the encoded permit in the url query param is removed.
As I was looking to sync our card-issuance branch I realized we have a mobile check function. https://github.com/ubiquity/pay.ubq.fi/compare/beta...development?expand=1#diff-8b45f88f73e078f719a15a90ca2cca60cd2276fff7786aa1d2739d2aec5ff905R7-R25
Lets only remove the encoded permit in the query param on mobile since that was the reason why the feature was implemented anyways (there is a bug on metamask mobile ui that was solved by removing the query param)
The text was updated successfully, but these errors were encountered: