Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom query params for test deployments #195

Closed
0x4007 opened this issue Mar 11, 2024 · 12 comments · Fixed by #214 or #232
Closed

Custom query params for test deployments #195

0x4007 opened this issue Mar 11, 2024 · 12 comments · Fixed by #214 or #232

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 11, 2024

In this repository we should include test query parameters for pull request reviews. I suppose we should test for 0 amount for both erc20 and erc721

I don't think the private key matters if it's for a 0 amount, but we should still be able to test from the UI.


Originally posted by @ubiquibot-continuous-deploys in #194 (comment)

@0x4007 0x4007 changed the title Custom query params for CD Custom query params for test deployments Mar 11, 2024
@gentlementlegen
Copy link
Member

@pavlovcik How about I make an action that you can run to generate as many permits as you need for testing? That would allow for a real test and no need to rebuild / redeploy.

@gentlementlegen
Copy link
Member

/start

Copy link

ubiquibot bot commented Mar 29, 2024

DeadlineFri, Mar 29, 8:22 AM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Apr 2, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Apr 2, 2024

[ 58.6 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification115
ReviewComment443.6
Conversation Incentives
CommentFormattingRelevanceReward
In this repository we should include test query parameters for p...
15
hr:
  count: 1
  score: "1"
  words: 0
115
This approach is decent but the specific problem I was aiming to...
14.40.5514.4
> @pavlovcik I realize that I need a wallet address to generate ...
7.2
code:
  count: 2
  score: "4"
  words: 2
0.567.2
> @pavlovcik an example of the comment can be found here: [gentl...
14
a:
  count: 2
  score: "4"
  words: 4
0.47514
> The current scenario is that I just update to the latest one b...
80.6458

[ 130.2 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask125
IssueComment10
IssueComment13.4
ReviewComment850.9
ReviewComment850.9
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik How about I make an action that you can run to genera...
-0.795-
@pavlovcik How about I make an action that you can run to genera...
3.40.7953.4
A workflow has been added to generate permits that have a value ...
11.20.58511.2
Of course makes sense. It would be possible to generate the link...
8
code:
  count: 1
  score: "1"
  words: 1
0.678
@pavlovcik I realize that I need a wallet address to generate th...
1.90.681.9
So I defaulted it to ubq.eth address to have the UI also behave ...
8.40.5258.4
@pavlovcik an example of the comment can be found here: https://...
5.90.4755.9
The current scenario is that I just update to the latest one bec...
6.60.716.6
@pavlovcik Here is a fix with a sample preview of three differen...
3.70.683.7
@pavlovcik fixed the `generate-permit.yml` comments on the varia...
5.2
code:
  count: 1
  score: "1"
  words: 3
0.675.2
A workflow has been added to generate permits that have a value ...
11.20.58511.2
Of course makes sense. It would be possible to generate the link...
8
code:
  count: 1
  score: "1"
  words: 1
0.678
@pavlovcik I realize that I need a wallet address to generate th...
1.90.681.9
So I defaulted it to ubq.eth address to have the UI also behave ...
8.40.5258.4
@pavlovcik an example of the comment can be found here: https://...
5.90.4755.9
The current scenario is that I just update to the latest one bec...
6.60.716.6
@pavlovcik Here is a fix with a sample preview of three differen...
3.70.683.7
@pavlovcik fixed the `generate-permit.yml` comments on the varia...
5.2
code:
  count: 1
  score: "1"
  words: 3
0.675.2

@0x4007
Copy link
Member Author

0x4007 commented Apr 2, 2024

Guess we probably should have increased the time estimate on this one.

Copy link

ubiquibot bot commented Jun 1, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Jun 1, 2024

[ 84.2 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification115
IssueComment12.4
ReviewComment666.8
Conversation Incentives
CommentFormattingRelevanceReward
In this repository we should include test query parameters for p...
15
hr:
  count: 1
  score: "1"
  words: 0
115
Guess we probably should have increased the time estimate on thi...
2.40.532.4
This approach is decent but the specific problem I was aiming to...
14.40.6914.4
> @pavlovcik I realize that I need a wallet address to genera...
7.2
code:
  count: 2
  score: "4"
  words: 2
0.657.2
> @pavlovcik an example of the comment can be found here: [ge...
14
a:
  count: 2
  score: "4"
  words: 4
0.6314
> The current scenario is that I just update to the latest on...
80.688
Something I just realized but if its posting both deploy styles ...
10.80.710.8
It is intended to be visually as close as possible to the curren...
12.40.6712.4

[ 446 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask1300
IssueComment10
IssueComment13.4
ReviewComment1171.3
ReviewComment1171.3
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik How about I make an action that you can run to genera...
-0.75-
@pavlovcik How about I make an action that you can run to genera...
3.40.753.4
A workflow has been added to generate permits that have a value ...
11.20.6311.2
Of course makes sense. It would be possible to generate the link...
8
code:
  count: 1
  score: "1"
  words: 1
0.548
@pavlovcik I realize that I need a wallet address to generate th...
1.90.651.9
So I defaulted it to ubq.eth address to have the UI also behave ...
8.40.678.4
@pavlovcik an example of the comment can be found here: https://...
5.90.755.9
The current scenario is that I just update to the latest one bec...
6.60.616.6
@pavlovcik Here is a fix with a sample preview of three differen...
3.70.653.7
@pavlovcik fixed the `generate-permit.yml` comments on the varia...
5.2
code:
  count: 1
  score: "1"
  words: 3
0.685.2
@pavlovcik Sure please let me know what you have in mind. I did ...
5.30.725.3
Here is a workflow that worked with the fix: https://github.com...
12.5
a:
  count: 3
  score: "3"
  words: 4
0.712.5
@rndquu The third deployment inside https://github.com/ubiquity/...
2.60.722.6
A workflow has been added to generate permits that have a value ...
11.20.6311.2
Of course makes sense. It would be possible to generate the link...
8
code:
  count: 1
  score: "1"
  words: 1
0.548
@pavlovcik I realize that I need a wallet address to generate th...
1.90.651.9
So I defaulted it to ubq.eth address to have the UI also behave ...
8.40.678.4
@pavlovcik an example of the comment can be found here: https://...
5.90.755.9
The current scenario is that I just update to the latest one bec...
6.60.616.6
@pavlovcik Here is a fix with a sample preview of three differen...
3.70.653.7
@pavlovcik fixed the `generate-permit.yml` comments on the varia...
5.2
code:
  count: 1
  score: "1"
  words: 3
0.685.2
@pavlovcik Sure please let me know what you have in mind. I did ...
5.30.725.3
Here is a workflow that worked with the fix: https://github.com...
12.5
a:
  count: 3
  score: "3"
  words: 4
0.712.5
@rndquu The third deployment inside https://github.com/ubiquity/...
2.60.722.6

[ 13.5 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment113.5
Conversation Incentives
CommentFormattingRelevanceReward
> Here is a workflow that worked with the fix: [gentlementleg...
13.5
a:
  count: 4
  score: "4"
  words: 6
code:
  count: 4
  score: "4"
  words: 6
0.7413.5

Copy link

[ 300 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 300
Issue Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
@pavlovcik How about I make an action that you can run to genera…
0
p:
  count: 35
  score: 1
0.845 -

[ 6.246 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 4.17
Issue Comment 1 2.076
Conversation Incentives
Comment Formatting Relevance Reward
In this repository we should include test query parameters for p…
6
p:
  count: 60
  score: 1
em:
  count: 6
  score: 0
0.695 4.17
Guess we probably should have increased the time estimate on thi…
2.4
p:
  count: 12
  score: 1
0.865 2.076

@0x4007
Copy link
Member Author

0x4007 commented Jun 1, 2024

Looks like the new one doesn't consider review comments.

@gentlementlegen
Copy link
Member

@0x4007 could be that or maybe it got stripped due to the quote, will investigate

@gentlementlegen
Copy link
Member

[ 550.8 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 300
Issue Comment 2 0
Review Comment 16 250.8
Conversation Incentives
Comment Formatting Relevance Reward
@pavlovcik How about I make an action that you can run to genera…
0
content:
  p:
    count: 35
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -
@0x4007 could be that or maybe it got stripped due to the quote,…
0
content:
  p:
    count: 15
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -
Resolves #195 <!-- - You must link the issue number e.g. "…
0
content:
  p:
    count: 3
    score: 1
  ul:
    count: 18
    score: 0
  li:
    count: 18
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -
You mean that the RPC URL doesn't work? It's okay since it is no…
18
content:
  p:
    count: 45
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 18
I gave an arbitrary value because it is not used throughout the …
10
content:
  p:
    count: 25
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 10
I cannot remove it as the script would fail to run due to missin…
8
content:
  p:
    count: 20
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 8
A workflow has been added to generate permits that have a value …
26.4
content:
  p:
    count: 66
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 26.4
Of course makes sense. It would be possible to generate the link…
27.6
content:
  p:
    count: 68
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.6
@pavlovcik I realize that I need a wallet address to generate th…
7.6
content:
  p:
    count: 19
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 7.6
So I defaulted it to ubq.eth address to have the UI also behave …
27.6
content:
  p:
    count: 69
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 27.6
@pavlovcik an example of the comment can be found here: https://…
19.6
content:
  p:
    count: 49
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 19.6
The current scenario is that I just update to the latest one bec…
25.6
content:
  p:
    count: 64
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 25.6
@pavlovcik Here is a fix with a sample preview of three differen…
10.8
content:
  p:
    count: 27
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 10.8
@pavlovcik fixed the `generate-permit.yml` comments on t…
12.8
content:
  p:
    count: 31
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 12.8
@pavlovcik Sure please let me know what you have in mind. I did …
14.8
content:
  p:
    count: 37
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 14.8
Resolves #195 <!-- - You must link the issue number e.g. "R…
0
content:
  p:
    count: 3
    score: 1
  ul:
    count: 18
    score: 0
  li:
    count: 18
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -
Here is a workflow that worked with the fix: https://github.com…
35.6
content:
  p:
    count: 85
    score: 1
  a:
    count: 4
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 35.6
@rndquu The third deployment inside https://github.com/ubiquity/…
6.4
content:
  p:
    count: 16
    score: 1
wordValue: 0.2
formattingMultiplier: 2
1 6.4

[ 55.06 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 5.9
Issue Comment 2 3.36
Review Comment 15 45.8
Conversation Incentives
Comment Formatting Relevance Reward
In this repository we should include test query parameters for p…
5.9
content:
  h2:
    count: 50
    score: 1
  p:
    count: 9
    score: 1
  em:
    count: 6
    score: 0
wordValue: 0.1
formattingMultiplier: 1
1 5.9
Guess we probably should have increased the time estimate on thi…
2.4
content:
  p:
    count: 12
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 1.92
Looks like the new one doesn't consider review comments.
1.8
content:
  p:
    count: 9
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 1.44
I think we can address my comments in separate pulls. Can I see …
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.7
This doesn't work
0.3
content:
  p:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.3
This looks like it's gonna keep posting comments. They need to b…
2.2
content:
  p:
    count: 22
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.2
Depends on what network. If you want to use mainnet I suggest ch…
2.1
content:
  p:
    count: 21
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.1
Empty strings are my least favorite values.
0.7
content:
  p:
    count: 7
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.7
```suggestion ```
0.1
content:
  pre:
    count: 1
    score: 0
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.1
```suggestion evmPrivateEncrypted: ``…
1.1
content:
  pre:
    count: 1
    score: 0
  code:
    count: 2
    score: 1
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.1
I generally would recommend importing a standalone typescript mo…
5.9
content:
  p:
    count: 58
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.9
I just realized we could make a faucet service if we transfer li…
3.5
content:
  p:
    count: 35
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.5
This approach is decent but the specific problem I was aiming to…
7.2
content:
  p:
    count: 72
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 7.2
`0x0` might be the most professional but there's also th…
1.6
content:
  p:
    count: 14
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 1.6
Do you have an example of it being appended? I see it made an ed…
3.9
content:
  p:
    count: 38
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.9
We have it implemented this way to ease review and debugging. If…
4
content:
  p:
    count: 40
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 4
Something I just realized but if its posting both deploy styles …
5.4
content:
  p:
    count: 54
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.4
It is intended to be visually as close as possible to the curren…
6.1
content:
  p:
    count: 61
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 6.1

[ 6 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Review Comment 2 6
Conversation Incentives
Comment Formatting Relevance Reward
@gentlementlegen Good job
0.3
content:
  p:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 0.3
You may use `secrets.UBIQUIBOT_APP_PRIVATE_KEY_TEST`. It…
5.7
content:
  p:
    count: 53
    score: 1
  code:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment