Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Claim Button #182

Closed
0x4007 opened this issue Feb 29, 2024 · 11 comments · Fixed by #187
Closed

View Claim Button #182

0x4007 opened this issue Feb 29, 2024 · 11 comments · Fixed by #187

Comments

@0x4007
Copy link
Member

0x4007 commented Feb 29, 2024

Create a "view claim" button to replace the "claim" button if the reward has already been claimed. Be sure to check this on page load. Make sure that the UI/UX flows well (i.e. no flickering and changing state of the button.)

  1. Use the provided SVG below as the icon.
  2. On mouseover make it say "View Claim"
<svg xmlns="http://www.w3.org/2000/svg" height="24" viewBox="0 -960 960 960" width="24"><path d="M212.309-140.001q-30.308 0-51.308-21t-21-51.308v-535.382q0-30.308 21-51.308t51.308-21h252.305V-760H212.309q-4.616 0-8.463 3.846-3.846 3.847-3.846 8.463v535.382q0 4.616 3.846 8.463 3.847 3.846 8.463 3.846h535.382q4.616 0 8.463-3.846 3.846-3.847 3.846-8.463v-252.305h59.999v252.305q0 30.308-21 51.308t-51.308 21H212.309Zm176.46-206.615-42.153-42.153L717.847-760H560v-59.999h259.999V-560H760v-157.847L388.769-346.616Z"/></svg>

654635bd pay-ubq-fi-bxp pages dev__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzIyNjM2ODQzOTQwMTI2MDM1NjU2NDA (3)

654635bd pay-ubq-fi-bxp pages dev__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzIyNjM2ODQzOTQwMTI2MDM1NjU2NDA (1)

I suppose for another task we should replace the claim button with the transaction hash if it has already been claimed or validated.

We can substitute the claim button with one that has this icon, and upon mouse over it can say "View Claim"

From #173 (comment)

@barebind
Copy link
Contributor

/assign

@0x4007
Copy link
Member Author

0x4007 commented Feb 29, 2024

/assign

The command is /start now! (For several months now!)

Copy link

ubiquibot bot commented Feb 29, 2024

@barebind the deadline is at 2024-02-29T15:10:49.584Z

@barebind
Copy link
Contributor

The command is /start now! (For several months now!)

I was confused a bit, I wanted to assign it to myself but can start tomorrow earliest :) so if anybody can start/finish earlier, please go ahead. if not I will be working on this tomorrow.

Copy link

ubiquibot bot commented Mar 6, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 6, 2024

[ 107 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification141
IssueComment11.8
ReviewComment764.2
Conversation Incentives
CommentFormattingRelevanceReward
Create a "view claim" button to replace the "claim" button if th...
41
li:
  count: 2
  score: "2"
  words: 17
code:
  count: 1
  score: "1"
  words: 0
141
> /assign

The command is /start now! (For several months now!...

1.80.61.8
Currently testing with [this](https://aa123d71.pay-ubq-fi-bxp.pa...
7.6

a:
  count: 1
  score: "2"
  words: 1
0.677.6
> this feature assumes that the permits are generated and insert...
16.40.4816.4
> > To clarify, this is not currently implemented? > > Doesn't ...
9.40.559.4
> I've tested it locally

Can you explain how I can test this...

4.40.674.4
I gave you edit access to our Supabase why not just insert the t...
8.20.678.2
> > I gave you edit access to our Supabase why not just insert t...
9.6

a:
  count: 2
  score: "4"
  words: 2
code:
  count: 1
  score: "2"
  words: 1
0.729.6
Love to see it.

<img width="834" alt="image" src="https://gi...

8.60.658.6

[ 257.1 WXDAI ]

@barebind
Contributions Overview
ViewContributionCountReward
IssueTask1200
IssueComment10
ReviewComment657.1
Conversation Incentives
CommentFormattingRelevanceReward
> The command is /start now! (For several months now!)

I was co...

-0.72-
> This does not work.

we are definitely not on the same page ...

9.1

code:
  count: 1
  score: "1"
  words: 2
0.759.1
> To clarify, this is not currently implemented? > > Doesn't ...
12.50.4912.5
> I'm not sure how we can confirm that your implementation works...
100.5710
> Can you explain how I can test this?

on my local

1- edit...

12.5

code:
  count: 6
  score: "6"
  words: 13
0.712.5
> I gave you edit access to our Supabase why not just insert the...
4.9
a:
  count: 2
  score: "2"
  words: 2
code:
  count: 1
  score: "1"
  words: 1
0.694.9
> Am I supposed to claim it? It has two rewards embedded, bot ar...
8.10.698.1

@barebind
Copy link
Contributor

barebind commented Mar 6, 2024

we still need to decide how to write the permit to the database at first place.
this merge request wouldn't work in production as there won't be any permits in the db.

@pavlovcik @rndquu

@0x4007
Copy link
Member Author

0x4007 commented Mar 6, 2024

we still need to decide how to write the permit to the database at first place.

Needs to be in the old bot code then. Feel free to make the specification in the correct repo.

@rndquu
Copy link
Member

rndquu commented Mar 6, 2024

we still need to decide how to write the permit to the database at first place. this merge request wouldn't work in production as there won't be any permits in the db.

@pavlovcik @rndquu

The bot should right permits to a DB.

TBH I don't understand which repository to use to create an issue for that:

@0x4007
Copy link
Member Author

0x4007 commented Mar 6, 2024

TBH I don't understand which repository to use to create an issue for that:

Current. Work on it here!

Next generation plugin (just initialized, doesn't do anything yet)

Next generation plugin (work in progress, but not ready!)

Next generation kernel (required to be stable to use plugins!)

@rndquu
Copy link
Member

rndquu commented Mar 6, 2024

we still need to decide how to write the permit to the database at first place. this merge request wouldn't work in production as there won't be any permits in the db.

@pavlovcik @rndquu

ubiquity-os-marketplace/text-conversation-rewards#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants