Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import @ubiquity/ubiquibot event handler logic #6

Closed
0x4007 opened this issue Jan 15, 2024 · 3 comments
Closed

Import @ubiquity/ubiquibot event handler logic #6

0x4007 opened this issue Jan 15, 2024 · 3 comments
Assignees

Comments

@0x4007
Copy link
Member

0x4007 commented Jan 15, 2024

The GitHub event handler logic should be imported to this new codebase, and be sure to be compatible with Cloudflare Workers.

  • No core node libraries like fs or path etc.
  • I don't anticipate this to be a problem with the event handler code.

We can break this apart into several pull requests. I imagine that some will be basically copy and paste, while others may require some refactoring. Perhaps the first deliverable can be the easy ones, and we can work our way to the more complex refactorings.

@0x4007 0x4007 changed the title Import @ubiquity/ubiquibot kernel logic Import @ubiquity/ubiquibot event handler logic Jan 15, 2024
@0x4007
Copy link
Member Author

0x4007 commented Jan 17, 2024

Probably a bad idea to rely on node polyfills but just wanted to leave this research here since it seems relevant in case of emergency https://developers.cloudflare.com/workers/wrangler/configuration/#add-polyfills-using-wrangler

@0x4007
Copy link
Member Author

0x4007 commented Jan 29, 2024

Let's not include any handlers in the kernel ubiquity/ubiquibot#906

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
Copy link

ubiquibot bot commented Jan 29, 2024

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants