-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized "GitHub Webhook + Contributor Role -> Rewards" No Config v1 #46
Generalized "GitHub Webhook + Contributor Role -> Rewards" No Config v1 #46
Comments
This comment was marked as spam.
This comment was marked as spam.
301 based on a very quick Look |
/start |
! Please set your wallet address with the /wallet command first and try again. |
/wallet 0x47c0C4eb25b0Aa4bC5D1E6341F5eE9A6aD2B596c |
+ Successfully registered wallet address |
/start |
Tip
|
Wanted to be sure about how the pull request is supposed to be created? Should I create a new folder with all files, since there are probably going to be multiple plugins here? |
It should be one plugin. Fork the plugin template and link your pull here |
This comment was marked as outdated.
This comment was marked as outdated.
@0x4007 may I ask for reviewing above PR? |
It's closed because you didn't follow the necessary instructions |
I was asking to review the one opened after the closed one (following instructions as suggested). Amit0617/contributor-rewards#3 particularly |
It's up for review. |
@kingsley-einstein Your PR seems to target your own repo somehow, I cannot assign reviewers there. |
@gentlementlegen |
It doesn't make sense, your PR should be opened against Ubiquity's organization, there should be a repo that would accommodate your changes. If there is none at the moment ask for one to be created. |
@gentlementlegen I know that now. Could one be created now, so I switch origins locally, and commit my changes? |
I tried adding github token, but the issues are still there. It turned out manifest file isn't being served correctly but the plugin should work smoothly with ubuiquity-os-kernel instances. I fixed manifest file issue and then the event being passed is null. So, it needs some attention to work smoothly with kernel as plugins are supposed to. Maybe try setting up a local instance to debug? Testing it only in your PR is helpful but it isn't sufficient. |
@EresDev |
Yes, the event I am trying is |
@0x4007 @gentlementlegen @EresDev I already built this plugin and met the targets of each spec for the whole parent task including unit tests. The org repo was deleted and my PR along with it for some reason before the task was broken into four steps. I'd like to submit my plugin for consideration for these tasks considering I already put in the work and the PR was received well at the time and is ready to go.
|
If it works according to the spec and you can prove it then sure. Although we would probably need to recreate the issue because a lot of conversation that doesn't belong under the issue happened here. |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
It's under review |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
Still under review botty. |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
Still under review botty! Sheesh! |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
Still under review. |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
under review |
2 similar comments
under review |
under review |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
1 similar comment
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
1 similar comment
@kingsley-einstein, this task has been idle for a while. Please provide an update. |
Still under review |
Dynamically map the config property name to count the amount of matching webhook events that occur in the issue/pull timeline, and credit accordingly. In which case, this plugin seems generally useful for mapping any value to any event, in the context of an issue or pull!
All this is intended to do is:
1
to every event that is counted, per contributor.In the next iteration, we should identify the user's "class" (specification author, assignee, collaborator, contributor)
In the final iteration, we should enable config.
The text was updated successfully, but these errors were encountered: