-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration action #29
Comments
It used to format with prettier: Also be careful not to run prettier on the Edit: I see now that the template does not use the |
segfaults aren't really a thing in the world of TypeScript - are you referring to prettier crashing due to memory constraints? Will importing the custom action close this issue? |
Node will overflow in memory, which I believe technically is a segfault (triggers a sigsegv), force of habit to use that word. Yes I believe using the custom action should resolve this issue. |
Oh I didn't notice that updating manifest is now part of the deploy action. |
The
update-configuration.yml
doesn't apply formatting according to the prettier configurationAlso I think it would be better to make this a custom action which would prevent duplication, we can use Typescript instead of writing code in the YML and allow us to change it without having to apply changes to every repo that forks plugin-template.
The only question is how to specify where the schema is located in the code, it could be something like this:
and then we can dynamically import it!
In the future we could also support different schema libraries (zod, joi...)
@0x4007 rfc
The text was updated successfully, but these errors were encountered: