Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typebox error handling and issue feedback #96

Open
Keyrxng opened this issue Aug 24, 2024 · 14 comments
Open

Typebox error handling and issue feedback #96

Keyrxng opened this issue Aug 24, 2024 · 14 comments

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Aug 24, 2024

An issue exists with the usage of T.Union which should be investigated and resolved.

It would also be handy to improve user feedback on the issue as a user must head to the workflow run to get a hint at what is going on.

I'm unsure what labels to assign, you would know better @gentlementlegen

original context

@tiilliir
Copy link

tiilliir commented Sep 4, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Sep 4, 2024

DeadlineWed, Sep 4, 8:01 PM UTC
Registered Wallet 0x58e83B330158Ba79de3caC0bC5B190F6eA000E69
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@tiilliir
Copy link

tiilliir commented Sep 5, 2024

‏/wallet
0x58e83b330158ba79de3cac0bc5b190f6ea000e69

Copy link
Contributor

ubiquity-os bot commented Sep 10, 2024

@tiilliir, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Sep 13, 2024

@tiilliir, this task has been idle for a while. Please provide an update.

@0x4007
Copy link
Member

0x4007 commented Sep 13, 2024

A double follow up with no update is unusual @gentlementlegen @Keyrxng can you guys investigate

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 14, 2024

A double follow up with no update is unusual @gentlementlegen @Keyrxng can you guys investigate

Looks like we need to exclude events like subscribed, mentioned. Below is the last two activity events for this task in respect to the contributor.

{
  id: 14254408264,
  node_id: 'MEE_lADOLUK0B86UFNt9zwAAAANRoQJI',
  url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408264',
  actor: {
    login: 'tiilliir',
    id: 180199616,
    node_id: 'U_kgDOCr2gwA',
    type: 'User',
    site_admin: false
  },
  event: 'mentioned',
  commit_id: null,
  commit_url: null,
  created_at: '2024-09-13T20:55:35Z',
  performed_via_github_app: null
} {
  id: 14254408270,
  node_id: 'SE_lADOLUK0B86UFNt9zwAAAANRoQJO',
  url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408270',
  actor: {
    login: 'tiilliir',
    id: 180199616,
    node_id: 'U_kgDOCr2gwA',
    type: 'User',
    site_admin: false
  },
  event: 'subscribed',
  commit_id: null,
  commit_url: null,
  created_at: '2024-09-13T20:55:35Z',
  performed_via_github_app: null
}

Can either of you think of other events we might need to handle and I or someone can look into it further via a task?

mentioned, subscribed, unsubscribed, reactions, comment.deleted and edited too I'd say...

@0x4007
Copy link
Member

0x4007 commented Sep 14, 2024

Not sure. Let's iterate until we get it right.

@0x4007
Copy link
Member

0x4007 commented Sep 14, 2024

Not sure. Let's iterate until we get it right.

Actually, perhaps it makes sense to do a whitelist approach.

  • opened pull
  • added commit
  • added pull comment
  • added issue comment

I think thats it for now.

Copy link
Contributor

ubiquity-os bot commented Sep 17, 2024

@tiilliir, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Sep 21, 2024

@tiilliir, this task has been idle for a while. Please provide an update.

@himanshuranjan007
Copy link

/start

Copy link

Warning! This task was created over 60 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Wed, Oct 23, 5:30 PM UTC
Beneficiary 0x6c7d7629bFe4A45873aDce05fd01e7B80d571071

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

Passed the deadline and no activity is detected, removing assignees: @himanshuranjan007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants