Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer comments are not retrieved properly #212

Open
gentlementlegen opened this issue Dec 12, 2024 · 5 comments
Open

Reviewer comments are not retrieved properly #212

gentlementlegen opened this issue Dec 12, 2024 · 5 comments
Assignees

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Dec 12, 2024

          For some reasons it seems that @whilefoo comments didn't get picked up here? I will have a look.

Originally posted by @gentlementlegen in ubiquity-os-marketplace/command-wallet#28 (comment)

What happened

Comments didn't seem to have been picked up for all the users in the linked pull-request reviews, specifically for user whilefoo in this case.

What was expected

The user should have had its comment accounted for in the final rewards.

How to reproduce

  • Run the local plugin the the linked issue
  • observe the missing results in the final rewards
@gentlementlegen gentlementlegen self-assigned this Dec 12, 2024
Copy link

! Error: Error: No labels are set.

Copy link

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 7 days if there is no activity.
  • Assignees will be disqualified after 14 days of inactivity.

Copy link

ubiquity-os-beta bot commented Dec 12, 2024

@0x4007
Copy link
Member

0x4007 commented Dec 12, 2024

[!IMPORTANT]

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 7 days if there is no activity.
  • Assignees will be disqualified after 14 days of inactivity.

We should only do disqualification when there are labels and it's funded

Also maybe you should put some effort into writing proper specs, at least until we get issue matching and task recommendation to work.

@gentlementlegen
Copy link
Member Author

@0x4007 Yes sorry it's more like a sticky note to me at the moment I will rewrite it in a sec.

We can disable disqualification on tasks that are not funded then, I will change this.

@gentlementlegen gentlementlegen changed the title For some reasons it seems that @whilefoo comments didn't get picked up here? I will have a look. Reviewer comments are not retrieved properly Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants