Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix "comment mismatch" issues #173

Closed
gentlementlegen opened this issue Oct 28, 2024 · 14 comments
Closed

Investigate and fix "comment mismatch" issues #173

gentlementlegen opened this issue Oct 28, 2024 · 14 comments

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Oct 28, 2024

          > Not the first time this error pops up, I wonder if it is just OpenAI not returning the proper JSON response or the logic being flawed.

@gentlementlegen You need to implement a fix

Originally posted by @0x4007 in ubiquity-os/plugins-wishlist#25 (comment)

It seems that during some runs the comment length returned by OpenAI does not match the length of the comments that were supposedly parsed.

Example:
ubiquity/work.ubq.fi#164 (comment)
ubiquity-os/plugins-wishlist#25 (comment)

@gentlementlegen
Copy link
Member Author

Since we had lots of changes (notably the prompt), I made sure to merge and re-ran the affected issues. They both ran fine. I will close this, and if the issue arises again, let's reopen.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@github-project-automation github-project-automation bot moved this to Done in Ubiquity Nov 22, 2024
@rndquu rndquu removed this from Development Nov 23, 2024
@gentlementlegen
Copy link
Member Author

Reopening due to: ubiquity-os/plugins-wishlist#50 (comment)

@gentlementlegen
Copy link
Member Author

/start

Copy link

! No price label is set to calculate the duration

@gentlementlegen
Copy link
Member Author

/start

Copy link

Warning! This task was created over 37 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Wed, Dec 4, 9:37 AM UTC
Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

Note

The following contributors may be suitable for this task:

rndquu

2% Match ubiquity/audit.ubq.fi#16

gentlementlegen

1% Match ubiquity-os-marketplace/daemon-pricing#47

0x4007

1% Match ubiquity/work.ubq.fi#125

@gentlementlegen
Copy link
Member Author

@sshivaditya2019 is that expected?

@sshivaditya2019
Copy link

@sshivaditya2019 is that expected?

Yes, there’s a new config to always add contributors, regardless of similarity. It's probably not working well at the moment, as the database doesn’t have many completed issues yet.

@0x4007
Copy link
Member

0x4007 commented Dec 5, 2024

Regressions shouldn't be rewarded

@rndquu rndquu removed this from Development Dec 5, 2024
@gentlementlegen
Copy link
Member Author

I investigated for quite some time and I can't repro it locally, not even with the API, and re-running it on the related task worked. Closing for now, to be reopened I suppose.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2024
0x4007 added a commit to ubiquity/.ubiquity-os that referenced this issue Dec 12, 2024
I was reviewing the conversation from ubiquity-os-marketplace/text-conversation-rewards#173 and realized that managers should be able to formally set it so they wont get funded (regressions)
0x4007 added a commit to ubiquity-os/.ubiquity-os that referenced this issue Dec 12, 2024
I was reviewing the conversation from ubiquity-os-marketplace/text-conversation-rewards#173 and realized that managers should be able to formally set it so they wont get funded (regressions)
0x4007 added a commit to ubiquity-os-marketplace/.ubiquity-os that referenced this issue Dec 12, 2024
I was reviewing the conversation from ubiquity-os-marketplace/text-conversation-rewards#173 and realized that managers should be able to formally set it so they wont get funded (regressions)
Copy link

! Priority value is not defined

Copy link

! Priority value is not defined

@0x4007
Copy link
Member

0x4007 commented Dec 12, 2024

! Priority value is not defined

@gentlementlegen looks like it doesn't know how to handle 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants