Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override any user relation if the user is ISSUE_ASSIGNEE #101

Closed
gentlementlegen opened this issue Aug 26, 2024 · 2 comments
Closed

Override any user relation if the user is ISSUE_ASSIGNEE #101

gentlementlegen opened this issue Aug 26, 2024 · 2 comments

Comments

@gentlementlegen
Copy link
Member

          There is a different multiplier for `ISSUE_AUTHOR` and `PULL_AUTHOR` as well as `PULL_ASSIGNED` and `ISSUE_ASSIGNEE`.

Keyrxng is:

Which is why the second one rewards him. This would imply changing the whole logic to look at the originally assigned user to the issue from the PR and then consider the relationship to be ISSUE_ASSIGNED to override the PULL_COLLABORATOR. I do not know how v1 worked on this regard (with the bug it had it would reward everything regardless).

Originally posted by @gentlementlegen in ubiquity/devpool-directory-tasks#31 (comment)

Overall, priority of statuses should be checked, and the highest relation status selected to apply the final rewards. In this scenario, since the user is ISSUE_ASSIGNEE at the time of the reward, that user should not be eligible for any reward.

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@0x4007
Copy link
Member

0x4007 commented Aug 26, 2024

I think we decided to defer this

Copy link
Contributor

ubiquity-os bot commented Aug 26, 2024

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants