-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: public access control #41
refactor: public access control #41
Conversation
The fix doesn't seem to fulfill the specification:
I do not see such change here. |
I see. Thanks for point out. Let me fix that. |
@gentlementlegen I think now the specification is fulfilled. |
@YanVictorSN, this task has been idle for a while. Please provide an update. |
@YanVictorSN The configuration variable should be called |
@YanVictorSN, this task has been idle for a while. Please provide an update. |
hi @gentlementlegen can you review and assign me again? Already did what you asked. |
@YanVictorSN The tests are failing and you have a conflict to resolve as well. I'll re-assign you this time, but you should timely provide work, and if you are waiting for a review, poke us in the pull-request so we can review it. |
@YanVictorSN, this task has been idle for a while. Please provide an update. |
Resolves #40