Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: public access control #41

Conversation

YanVictorSN
Copy link

Resolves #40

@gentlementlegen
Copy link
Member

The fix doesn't seem to fulfill the specification:

  • Refactor publicAccessControl to only be a boolean called: fundContributorClosedIssue, default is false.

I do not see such change here.

@YanVictorSN
Copy link
Author

The fix doesn't seem to fulfill the specification:

  • Refactor publicAccessControl to only be a boolean called: fundContributorClosedIssue, default is false.

I do not see such change here.

I see. Thanks for point out. Let me fix that.

@YanVictorSN
Copy link
Author

The fix doesn't seem to fulfill the specification:

  • Refactor publicAccessControl to only be a boolean called: fundContributorClosedIssue, default is false.

I do not see such change here.

@gentlementlegen I think now the specification is fulfilled.

Copy link
Contributor

@YanVictorSN, this task has been idle for a while. Please provide an update.

@gentlementlegen
Copy link
Member

@YanVictorSN The configuration variable should be called fundContributorClosedIssue, and please resolve the conflicts.

Copy link
Contributor

@YanVictorSN, this task has been idle for a while. Please provide an update.

@YanVictorSN
Copy link
Author

hi @gentlementlegen can you review and assign me again? Already did what you asked.

@gentlementlegen
Copy link
Member

gentlementlegen commented Nov 8, 2024

@YanVictorSN The tests are failing and you have a conflict to resolve as well.

I'll re-assign you this time, but you should timely provide work, and if you are waiting for a review, poke us in the pull-request so we can review it.

Copy link
Contributor

@YanVictorSN, this task has been idle for a while. Please provide an update.

@ubiquity-os-beta ubiquity-os-beta bot closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor publicAccessControl
3 participants