Do Not Disqualify on Approval

[0x4007]

daemon-merging doesn't have a chance to run properly if disqualifications happen on approved pulls. This should be fixed by halting the disqualifier logic once they received an approval.

Even if an argument is made around "increasing coupling" it still doesn't make sense to disqualify somebody after their deliverable has been approved, and there are delays from the other reviewers.

My gut feeling is that disqualification should continue to run on review states for "commented" and "request changes"

Perhaps in the future, a minor optimization could be to enforce that the conversations from the "commented" review must be resolved in order to halt disqualification, but this is easily gamed as I've seen assignees "resolve" comments without actually handling them. We would need to have more advanced logic to compare the diff with the review comments to see if they were actually addressed.

---

https://t.me/UbiquityDevPool/2990

Passed the deadline and no activity is detected, removing assignees: @kingsley-einstein.

Originally posted by @ubiquity-os[bot] in ubiquity/uusd.ubq.fi#1 (comment)

[ubiquity-os-beta]

Note

The following contributors may be suitable for this task:

gentlementlegen

1% Match ubiquity-os/ubiquity-os-kernel#125

[ishowvel]

/start

[ubiquity-os-beta]

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

[henalolp]

/help

[ubiquity-os-beta]

Available Commands

Command	Description	Example
/help	List all available commands.	/help
/allow	Allows the user to modify the given label type.	/allow @user1 label
/ask	Ask any question about the repository, issue or pull request	/ask
/query	Returns the user's wallet, access, and multiplier information.	/query @UbiquityOS
/start	Assign yourself and/or others to the issue/task.	/start
/stop	Unassign yourself from the issue/task.	/stop
/wallet	Register your wallet address for payments.	/wallet ubq.eth

[henalolp]

/wallet 0x226AAE6Db84dca652818400750b8BF96a077349e

[ubiquity-os-beta]

+ Successfully registered wallet address

[henalolp]

/start

[ubiquity-os-beta]

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)