From 42d1512b5367d8b72dc223fc173ff6a8d2a3d858 Mon Sep 17 00:00:00 2001 From: Alan Zeino Date: Tue, 6 Feb 2018 09:49:49 -0800 Subject: [PATCH] Update iOS Deployment Target to 8.1 (#11) * Update iOS Deployment Target to 8.1 * Update the Podfile in the demo app, [!] No `Podfile' found in the project directory. the demo app too --- FBSnapshotTestCase.xcodeproj/project.pbxproj | 6 ++++-- .../FBSnapshotTestCaseDemo.xcodeproj/project.pbxproj | 2 ++ FBSnapshotTestCaseDemo/Podfile | 2 +- FBSnapshotTestCaseDemo/Podfile.lock | 12 ++++++------ README.md | 2 +- iOSSnapshotTestCase.podspec | 2 +- 6 files changed, 15 insertions(+), 11 deletions(-) diff --git a/FBSnapshotTestCase.xcodeproj/project.pbxproj b/FBSnapshotTestCase.xcodeproj/project.pbxproj index bd36c3a..c87bf0b 100644 --- a/FBSnapshotTestCase.xcodeproj/project.pbxproj +++ b/FBSnapshotTestCase.xcodeproj/project.pbxproj @@ -618,7 +618,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; MTL_ENABLE_DEBUG_INFO = YES; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; @@ -667,7 +667,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 8.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; MTL_ENABLE_DEBUG_INFO = NO; SDKROOT = iphoneos; SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule"; @@ -695,6 +695,7 @@ ); INFOPLIST_FILE = "FBSnapshotTestCase/FBSnapshotTestCase-Info.plist"; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; OTHER_LDFLAGS = ( "$(inherited)", @@ -725,6 +726,7 @@ ); INFOPLIST_FILE = "FBSnapshotTestCase/FBSnapshotTestCase-Info.plist"; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; OTHER_LDFLAGS = ( "$(inherited)", diff --git a/FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo.xcodeproj/project.pbxproj b/FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo.xcodeproj/project.pbxproj index 47e8cbe..d086f6f 100644 --- a/FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo.xcodeproj/project.pbxproj +++ b/FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo.xcodeproj/project.pbxproj @@ -501,6 +501,7 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = "Brand Assets"; INFOPLIST_FILE = "FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo-Info.plist"; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -515,6 +516,7 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = "Brand Assets"; INFOPLIST_FILE = "FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo-Info.plist"; + IPHONEOS_DEPLOYMENT_TARGET = 8.1; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; diff --git a/FBSnapshotTestCaseDemo/Podfile b/FBSnapshotTestCaseDemo/Podfile index 49d25e8..7de55c9 100644 --- a/FBSnapshotTestCaseDemo/Podfile +++ b/FBSnapshotTestCaseDemo/Podfile @@ -1,5 +1,5 @@ source 'https://github.com/CocoaPods/Specs.git' -platform :ios, '8.0' +platform :ios, '8.1' use_frameworks! diff --git a/FBSnapshotTestCaseDemo/Podfile.lock b/FBSnapshotTestCaseDemo/Podfile.lock index dac9bd5..9a910ed 100644 --- a/FBSnapshotTestCaseDemo/Podfile.lock +++ b/FBSnapshotTestCaseDemo/Podfile.lock @@ -1,8 +1,8 @@ PODS: - - iOSSnapshotTestCase (2.1.6): - - iOSSnapshotTestCase/SwiftSupport (= 2.1.6) - - iOSSnapshotTestCase/Core (2.1.6) - - iOSSnapshotTestCase/SwiftSupport (2.1.6): + - iOSSnapshotTestCase (2.2.0): + - iOSSnapshotTestCase/SwiftSupport (= 2.2.0) + - iOSSnapshotTestCase/Core (2.2.0) + - iOSSnapshotTestCase/SwiftSupport (2.2.0): - iOSSnapshotTestCase/Core DEPENDENCIES: @@ -13,8 +13,8 @@ EXTERNAL SOURCES: :path: .. SPEC CHECKSUMS: - iOSSnapshotTestCase: dc636173d7398d13e99b809852472a3eb125fc2e + iOSSnapshotTestCase: 810eb3afdec51713b6d436810b23949ba626f393 -PODFILE CHECKSUM: f7c02939e680d02f0dc6d6ca206b0e331905837a +PODFILE CHECKSUM: 23fc15db0c3233d57acaa5dbafbc9f5f89f2f477 COCOAPODS: 1.3.1 diff --git a/README.md b/README.md index 89da232..32bf3b8 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ Installation with CocoaPods end ``` - If you support iOS 7 use `iOSSnapshotTestCase/Core` instead, which doesn't contain Swift support. + If your test target is Objective-C only use `iOSSnapshotTestCase/Core` instead, which doesn't contain Swift support. Replace "Tests" with the name of your test project. diff --git a/iOSSnapshotTestCase.podspec b/iOSSnapshotTestCase.podspec index 4920bc8..f131641 100644 --- a/iOSSnapshotTestCase.podspec +++ b/iOSSnapshotTestCase.podspec @@ -15,7 +15,7 @@ Pod::Spec.new do |s| s.author = 'Uber' s.source = { :git => "https://github.com/uber/ios-snapshot-test-case.git", :tag => s.version.to_s } - s.ios.deployment_target = '7.0' + s.ios.deployment_target = '8.1' s.tvos.deployment_target = '9.0' s.requires_arc = true s.frameworks = 'XCTest','UIKit','Foundation','QuartzCore'