Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit ToC backfill mechanism #344

Open
ilijapuaca opened this issue Jan 6, 2021 · 1 comment
Open

Revisit ToC backfill mechanism #344

ilijapuaca opened this issue Jan 6, 2021 · 1 comment

Comments

@ilijapuaca
Copy link
Contributor

I ran into an issue where ToC backfill mechanism did not work properly in #342, but I do see it being brought up in a few other places. Simplifying the implementation around ToC generation would allow for quite a big chunk of complex code that handles race condition in node processing to go away, and would likely allow for easier maintenance.

One potential way to do this would be moving node processing from onCreateNode to sourceNodes, not sure if there are any practically issues with doing so, but it could be an easy transition
@ilijapuaca
Copy link
Contributor Author

cc @ibgreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilijapuaca