uBlock keeping show updating filters even if complete

[0x391F]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

uBlock keeping show updating filters even if complete.

A specific URL where the issue occurs.

N/A

Steps to Reproduce

1. Update filters
2. Wait a few minutes
3. It still show updating, but if you refresh the page, it will show that the update has been complete (the updating indicator stop).

Expected behavior

It should stop the updating indicator.

Actual behavior

The updating indicator should auto stop after complete.

uBO version

1.56.0

Browser name and version

Firefox 123.0 and latest Nightly (125.0a1)

Operating System and version

Windows 10 LTSC 2021 x64 and Windows 11 VM

[0x391F]

2024-02-25.10-13-54.mp4

[gwarser]

"1. Update filters"

How? They update automatically just after you open the dashboard. What you did exactly?

[0x391F]

"1. Update filters"

How? They update automatically just after you open the dashboard. What you did exactly?

For example, everyday I check uBlock Origin filters update manually because the filters update should complete before it run in sandboxie - I almost always run firefox in sandboxie.

[gwarser]

Is this reproducible? Can you record video from the start (before you open the browser)?

[gorhill]

I almost always run firefox in sandboxie.

Then possibly uBO is having trouble accessing its storage to cache the fetched data related to updating. To find out if this is a uBO-specific issue, you could try with other content blockers. If they also suffer similar issue, then the issue is specific to you and you will have to figure how to address it on your side.

Please look at the extension dev console to see if it says something:

• Go to about:addons
• Gear icon => "Debug Add-ons"
• Find uBO => Click "Inspect"
• Select "Console" pane

If something seems to be related to your issue, report it here.

[0x391F]

I think this bug is appears since a version of uBlock, it used to auto stop loading, but it doesn't work after a certain day and/or uBlock Origin version.

[0x391F]

I test on 1.54.0, this bug doesn't reproduce.

[0x391F]

This bug maybe caused by that uBlock Origin won't update the indicator status even if filters update have been complete.

[gorhill]

maybe caused

There is no point speculating, if we can't reproduce it's because there is something specific on your side triggering the issue. The goal is to identify what is that specific trigger on your side. This is why I asked:

Please look at the extension dev console

Also, investigate whether sandboxie is that trigger.

[0x391F]

Also, investigate whether sandboxie is that trigger.

I can confirm it is not sandboxie trigger this bug, in #3138 (comment), this bug also happens on Windows 11 vm without runing in sandboxie.

[gorhill]

Please look at the extension dev console

Also, provide troubleshooting information from Support pane.

[0x391F]

Please look at the extension dev console to see if it says something:

* Go to `about:addons`

* Gear icon => "Debug Add-ons"

* Find uBO => Click "Inspect"

* Select "Console" pane

If something seems to be related to your issue, report it here.

Here's no items in console.

[0x391F]

uBlock Origin: 1.56.0
Firefox: 123
filterset (summary):
 network: 354802
 cosmetic: 103182
 scriptlet: 36718
 html: 1786
listset (total-discarded, last-updated):
 added:
  adguard-generic: 79275-5381, 6h.46m
  adguard-mobile: 9090-102, 6h.46m
  adguard-spyware-url: 1467-106, 6h.46m
  adguard-spyware: 113905-33606, 6h.46m
  block-lan: 56-0, 21d.8h.28m
  curben-phishing: 104549-39, 7m
  dpollock-0: 11649-492, 3d.6h.48m
 default:
  user-filters: 0-0, never
  ublock-filters: 37633-146, 9m Δ
  ublock-badware: 8009-14, 9m Δ
  ublock-privacy: 741-0, 9m Δ
  ublock-unbreak: 2280-1, 9m Δ
  ublock-quick-fixes: 106-1, 9m Δ
  easylist: 81757-863, 9m Δ
  easyprivacy: 50285-990, 9m Δ
  urlhaus-1: 8770-0, 7m
  plowe-0: 3782-1, 4d.6h.56m
  CHN-0: 25354-156, 1d.6h.18m
filterset (user): [empty]
userSettings:
 prefetchingDisabled: false
hiddenSettings: [none]
supportStats:
 allReadyAfter: 1007 ms
 maxAssetCacheWait: 535 ms
 cacheBackend: indexedDB

[gorhill]

Can you record video from the start (before you open the browser)?

It's not clear how you force an update, your video just show the issue itself, not what was done to make the issue appear.

[Iz-zzzzz]

I also encounter this issue occasionally, but I'm unable to reproduce it consistently.

At that time, I simply opened my browser, navigated to uBlock Origin settings, and noticed that they were loading indefinitely.

Brave Browser Stable latest version (Windows 11 uBlock v1.56.01)
Firefox Stable 123.0 (Windows 11 uBlock v1.56.04 and Android 13 uBlock v1.56)

[0x391F]

This bug also happens on a new-install Fenix (Firefox for Android) 123.0 with uBlock Origin 1.56.0.

[Iz-zzzzz]

It seems that this issue may have been caused by repeatedly restoring and backing up uBO settings from an older version until recent version. I resolved it by resetting uBO and configuring everything from scratch.

(2024-03-24) Edit : It doesn't fix the issue.

[0x391F]

This bug doesn't happens on uBlock Origin 1.56.0 with Edge 122.0.2365.92.

[gwarser]

This always happen to all lists? Not only few which have been outdated at the time?

[0x391F]

Not only few which have been outdated at the time?

Yes, it only happens on out-of-date lists.

[0x391F]

Video from #3138 (comment) is broken for me, on all browsers (Firefox , Opera , Edge), when Play is clicked, seek bar jumps instantly to the end, I don't know whether the video has been removed, or is private or is broken, nor I know why.

For me, it plays without any problem on Firefox and Edge, maybe there's something wrong with your network.

[traceyfedora]

What I have observed is that this bug shows on a clean install of uBlock on a clean new Firefox profile with the latest main release version of Firefox on either Windows or macOS, but only if the filter lists settings are opened in private windows.

Steps I took to reproduce it reliably:

1. Launch Firefox from a new profile
   In cmd.exe on Windows:
   mkdir %userprofile%\Downloads\ff-temp
cd %userprofile%\Downloads\ff-temp
"C:\Program Files\Mozilla Firefox\firefox.exe" -new-instance -profile . -private-window https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/
   In Terminal.app on macOS:
   mkdir ~/Downloads/ff-temp
cd ~/Downloads/ff-temp
/Applications/Firefox.app/Contents/MacOS/firefox --new-instance --profile . --private-window https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/

2. Install uBlock and, importantly, enable "Allow this extension to run in Private Windows"

3. Open uBlock settings -> filter lists in a private window and see the throbbers animating indefinitely.
   Or if there are no throbbers currently animating click on any of the watch icons ⏱️ to force an update and see the never ending animation.

When the filters technically are done updating but the animation is still ongoing then a refresh of the filter lists settings page shows the completed status and stops the animation. The same works when you temporarily navigate to a different settings page, i.e. my filters, and then jump back to the filter lists page.

This bug does not happen if you open the settings and update the filter lists in a non-private window. There, all the animations finish correctly when the lists are successfully updated.

[traceyfedora]

It seems to have started with the uBlock update from version 1.54.0 to version 1.55.0.

In 1.54 when you clicked on the watch icon to purge the cache of the specific list the icon would change to a orange triangle with an exclamation mark inside of it. At the same time the 'update now' button would change from gray to blue and the text would say 'update now'. After you pressed the now blue button the list with the orange icon would update, the blue button would animate and eventually change back to gray, and the orange icon would change back to a now green stopwatch.

In 1.55 when you click on the watch icon to purge the cache of the specific list you get the current day behavior: the watch icon of the specific list changes to an animating throbber whilst the update now button changes from gray to blue and also begins to animate. But the animation never stops if the filter list is opened in a private window. The same procedure repeated in a non-private window works as expected and the animation finishes when the lists are successfully updated.

[0x391F]

What I have observed is that this bug shows on a clean install of uBlock on a clean new Firefox profile with the latest main release version of Firefox on either Windows or macOS, but only if the filter lists settings are opened in private windows.

This bug does not happen if you open the settings and update the filter lists in a non-private window. There, all the animations finish correctly when the lists are successfully updated.

Yes, you're right.

[gorhill]

After a quick investigation, it appears BroadcastChannel does not work to send messages from non-private to private contexts. The result is that when the dashboard is opened in a private window, it never receives the broadcast channel messages from the non-private background process of uBO.