Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

money.pl: detection #12214

Closed
7 of 8 tasks
Infiexe opened this issue Mar 13, 2022 · 294 comments · Fixed by MajkiIT/polish-ads-filter#22235, MajkiIT/polish-ads-filter#22237, MajkiIT/polish-ads-filter#22261, MajkiIT/polish-ads-filter#22288 or MajkiIT/polish-ads-filter#22289
Closed
7 of 8 tasks

money.pl: detection #12214

Infiexe opened this issue Mar 13, 2022 · 294 comments · Fixed by MajkiIT/polish-ads-filter#22235, MajkiIT/polish-ads-filter#22237, MajkiIT/polish-ads-filter#22261, MajkiIT/polish-ads-filter#22288 or MajkiIT/polish-ads-filter#22289
Labels
fixed by regional list

Comments

@Infiexe
Copy link

Infiexe commented Mar 13, 2022 •
edited
Loading

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO (also mind browser built-in blockers)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://www.money.pl/

Category

detection

Describe the issue

unusable with ublock origin on

Screenshot(s)

Screenshot(s)

obraz

Configuration

uBlock Origin: 1.41.8
Firefox: 98
filterset (summary): 
  network: 81641
  cosmetic: 48862
  scriptlet: 16671
  html: 635
listset (total-discarded, last updated): 
  default: 
    user-filters: 0-0, never
    ublock-filters: 30836-70, 1h.19m
    ublock-badware: 3971-3, 1h.17m
    ublock-privacy: 204-0, 1h.16m
    ublock-abuse: 72-0, 1h.15m
    ublock-unbreak: 1737-0, 1h.14m
    easylist: 64610-619, 1h.13m
    easyprivacy: 26669-570, 1h.12m
    urlhaus-1: 8437-0, 1h.11m
    plowe-0: 3674-2, 6d.20h.54m
    POL-0: 7784-25, 1h.10m
    POL-2: 1276-12, 1d.17h.9m
filterset (user): [empty]
trustedset: 
  added: [array of 6 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 146 ms (selfie)
  maxAssetCacheWait: 136 ms
popupPanel: 
  blocked: 40
  blockedDetails: 
    3lift.com: 1
    adform.net: 1
    adnxs.com: 3
    amazon-adsystem.com: 1
    casalemedia.com: 1
    connectad.io: 2
    creativecdn.com: 2
    criteo.com: 1
    criteo.net: 4
    facebook.net: 1
    gemius.pl: 1
    google-analytics.com: 1
    googletagmanager.com: 1
    googletagservices.com: 1
    id5-sync.com: 2
    indexww.com: 1
    openx.net: 2
    pubmatic.com: 3
    rubiconproject.com: 2
    sharethrough.com: 4
    smartadserver.com: 4
    wp.pl: 1
@krystian3w
Copy link
Contributor

WP.pl company update this pop-up in 48 h after commit for uBO but no follow that fast AdamWr fixes added to AdGuard Base.

@ghost
Copy link

ghost commented Mar 13, 2022

WP.pl company update this pop-up in 48 h after commit for uBO but no follow that fast AdamWr fixes added to AdGuard Base.

Wouldn't it be best if this was addressed in a regional list then?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022 •
edited
Loading

IMO out of scope for Olegwukr aka MajkiIT knowledge about JavaScript also we have gorhill privileges to omit fix WP.pl company due too fastly recover ads/anti-adblock by this company (this was wrote on reddit or github older issue).

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022 •
edited
Loading

update ok i get it too but what makes this site different to other sites doing the same like dg?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022 •
edited
Loading

Money like test diffrent article layouts as A/B test, maybe one have disabled anti-adblock pop-up.

different to other sites doing the same like dg?

have reached master level in debugging their code.

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022 •
edited
Loading

Ok redirecting not working.

Seems to be only a overlay which can be removed or does only removing cause breakage?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022 •
edited
Loading

But overlay-buster can break page and the past we tested :matches-css to hide only that pop-up and fastly overrided to uknown number beetween 0-1 e.g. 0,00203440434px as top: in CSS.

Also pop-up can stop run other javascript at page, so few anti-annoyance filters no longer works (needed is rewrite to support both scenarios if e.g. share buttons back).

Also text are fastly changed by use 0-width characters to avoid use :has-text or :has.

@JobcenterTycoon
Copy link
Contributor

So what about to hide every element after the <body> tag except the legit ones? like

money.pl##body > *:not([style]):not(#WP-cookie-info):not(#app):not(#popover):not(a):not(div > div > div + div > div + div:has-text(Cenimy Twoją prywatność)) (just an example i not deep tested for breakage)

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022 •
edited
Loading

my filter leaves the cookie banner untouched it only affect the anti adblock overlay

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022 •
edited
Loading

I suppose fastly paste fake style attrib, invalid values in ID. IMO no deteled bug with frozen objects: AdguardTeam/AdGuardExtra#52 (comment)

@JobcenterTycoon
Copy link
Contributor

Yep, but its possible to do a deeper selection like i did for the cookie banner :not(div > div > div + div > div + div:has-text(Cenimy Twoją prywatność))

I not know do they watch uBO so often after no fix for many month? The p-p-s-s issue got fixed 6 days ago and the filters still working fine

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022 •
edited
Loading

what about

*$script,domain=money.pl,redirect-rule=noopjs
money.pl#@#+js()
||wp.pl^$frame,domain=money.pl
||v.wpimg.pl/*.html$frame
money.pl##:xpath(//*[string-length(@href) > 1600])
money.pl#@#.ads

remaining PH

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022 •
edited
Loading

May start load iframe from this domain range:

abczdrowie.pl,allani.pl,autocentrum.pl,autokult.pl,dobramama.pl,dobregry.pl,dobreprogramy.pl,domodi.pl,echirurgia.pl,extradom.pl,fotoblogia.pl,gadzetomania.pl,homebook.pl,jejswiat.pl,kafeteria.pl,kafeteria.tv,kardiolo.pl,kazimierzdolny.pl,komorkomania.pl,luxlux.pl,medycyna24.pl,mixer.pl,nerwica.com,nocowanie.pl,o2.pl,open.fm,parenting.pl,pinger.pl,pogodnie.pl,polygamia.pl,pudelek.pl,pudelek.tv,pudelekx.pl,pytamy.pl,samosia.pl,smaczneblogi.pl,smog.pl,snobka.pl,so-magazyn.pl,superauto.pl,testwiedzy.pl,totalmoney.pl,vibez.pl,vpolshchi.pl,wakacje.pl

so maybe better convert to denyallow=

@JobcenterTycoon
Copy link
Contributor

It works but only with disabled regional filter list POL: Oficjalne Polskie Filtry do AdBlocka, uBlocka Origin i AdGuarda

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

I didn't disable the regional lists, for those => money.pl#@#+js()

@krystian3w
Copy link
Contributor

Maybe it is time send official wake up to MajkiIT/Olegwukr to add some new persons with write premissions to create lists more active than 1 commit at 1-2 weeks.

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022 •
edited
Loading

The cosmetic filter pl##.ads flags -> Anti adblock and ads after accepting the cookie banner

money.pl#@#.ads need to be added too to make the filter working with enabled regional POL: filter list too.

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022 •
edited
Loading

added to the filters above

money.pl##:xpath(//*[string-length(@href) > 1600])

and yes needing
money.pl#@#.ads

no anti adb, no ads, only PH

@JobcenterTycoon
Copy link
Contributor

seems to be working fine for wp.pl and other subsites too

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

Like for the russian sites (where there is an unofficial list disabled by default but recommended by the maintainers on forum - RU AdList: Counters, fixing nasty / circumventing filters pages), maybe the polish maintainers should maintain an unofficial list too.

@JobcenterTycoon
Copy link
Contributor

Do you mean it will not be fixed in uAssets right now?

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

If I'll add the filters in a list enabled by default they will react quickly I guess.
What do you think @okiehsch ?
We could also create here in uAssets a ... "special" list just for such cases (disabled by default)

@JobcenterTycoon
Copy link
Contributor

@mapx- do you remember the thing i did for the site with the red logo? It can be working for this site too but only cosmetic filtering is possible

@okiehsch
Copy link
Contributor

We could also create here in uAssets a ... "special" list just for such cases (disabled by default)

We already have a "special" not enabled list in uAssets, so I am not against it.
Would it not be good enough to post a working fix in the corresponding issue in cases such as this, i.e. the site counters our filters very quickly.

mapx- added a commit that referenced this issue Mar 14, 2022
@mapx-
https://github.com/uBlockOrigin/uAssets/issues/12214
4cb071f
@mapx-
Copy link
Contributor

mapx- commented Mar 14, 2022 •
edited
Loading

@JobcenterTycoon just add other such filters in the new list

@okiehsch we could include the new list as include in our annoyances list (not enabled by default)

@okiehsch
Copy link
Contributor

okiehsch commented Mar 14, 2022 •
edited
Loading

@okiehsch we could include the new list as include in our annoyances list (not enabled by default)

If we add such fixes to a list it should be in a separate list imo.
Similar to https://github.com/uBlockOrigin/uAssets/blob/master/filters/lan-block.txt

@gorhill what do you think.

@gorhill
Copy link
Member

gorhill commented Mar 14, 2022

Ok, how about "uBlock filters – Quick fixes", disabled by default, update every day if enabled? We would need to keep it as small as possible.

@JobcenterTycoon JobcenterTycoon mentioned this issue Mar 14, 2022
Merged
@mapx-
Copy link
Contributor

mapx- commented Mar 14, 2022

renamed quick-fixes.txt

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Sep 8, 2024 •
edited
Loading

Blocking the iFrame breaks videos because videos are attached to the cookie banner which is embedded inside the iFrame, this is why i removed the filter in the past. With latest filter i get no placeholder.

@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
JobcenterTycoon added a commit that referenced this issue Sep 22, 2024
@JobcenterTycoon
address #12214 (comment)
b39308d
@garry-ut99

This comment was marked as abuse.

Sign in to view
JobcenterTycoon added a commit that referenced this issue Sep 23, 2024
@JobcenterTycoon
address #12214 (comment)
619b7c8
@garry-ut99

This comment was marked as abuse.

Sign in to view
@krystian3w
Copy link
Contributor

krystian3w commented Oct 1, 2024 •
edited
Loading

Something broke mobile: https://www.money.pl/gospodarka/tubki-z-alkoholem-7076924881226592a.html

!#if env_mobile
money.pl#@##app > div > div:has(> div:only-child > div > a:first-child > div:empty)
!#endif

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Oct 1, 2024 •
edited
Loading

What is broken? I get no match in the logger. Edit: i get also no match on desktop, removed for now.

@krystian3w
Copy link
Contributor

krystian3w commented Oct 1, 2024 •
edited
Loading

At my FX 130 page was blank of text and images: https://github.com/user-attachments/assets/1d0b1f63-cabe-4032-8675-00030b5d8d0a

@garry-ut99

This comment was marked as abuse.

Sign in to view
@JobcenterTycoon
Copy link
Contributor

Should be all fine now.

@garry-ut99

This comment was marked as abuse.

Sign in to view
JobcenterTycoon added a commit that referenced this issue Oct 5, 2024
@JobcenterTycoon
address #12214 (comment)
d756373
@garry-ut99

This comment was marked as abuse.

Sign in to view
JobcenterTycoon added a commit that referenced this issue Oct 6, 2024
@JobcenterTycoon
address #12214 (comment)
6976b3e
@garry-ut99

This comment was marked as abuse.

Sign in to view
JobcenterTycoon added a commit that referenced this issue Oct 6, 2024
@JobcenterTycoon
address #12214 (comment)
3247565
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
@garry-ut99

This comment was marked as abuse.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed by regional list
Projects
None yet
Milestone
No milestone