From 52dd11bb04ed1bdcbb4c7b2316d1f3f7a999da6b Mon Sep 17 00:00:00 2001
From: Dane Powell <git@danepowell.com>
Date: Tue, 26 Nov 2024 12:04:52 -0800
Subject: [PATCH] More PHP 8.4 fixes (#484)

---
 src/Endpoints/Code.php              | 4 +---
 src/Endpoints/Crons.php             | 8 ++------
 src/Endpoints/Roles.php             | 3 +--
 src/Endpoints/SslCertificates.php   | 7 ++-----
 src/Exception/ApiErrorException.php | 2 +-
 5 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/src/Endpoints/Code.php b/src/Endpoints/Code.php
index 69beda86..d64c3493 100644
--- a/src/Endpoints/Code.php
+++ b/src/Endpoints/Code.php
@@ -51,13 +51,11 @@ public function switch(string $environmentUuid, string $branch): OperationRespon
 
     /**
      * Deploys code from one environment to another environment.
-     *
-     * @param string|null $commitMessage
      */
     public function deploy(
         string $environmentFromUuid,
         string $environmentToUuid,
-        string $commitMessage = null
+        ?string $commitMessage = null
     ): OperationResponse {
 
         $options = [
diff --git a/src/Endpoints/Crons.php b/src/Endpoints/Crons.php
index 2f0ca85a..095b1d00 100644
--- a/src/Endpoints/Crons.php
+++ b/src/Endpoints/Crons.php
@@ -46,15 +46,13 @@ public function get(string $environmentUuid, int $cronId): CronResponse
 
     /**
      * Add a cron task.
-     *
-     * @param string|null $serverId
      */
     public function create(
         string $environmentUuid,
         string $command,
         string $frequency,
         string $label,
-        string $serverId = null
+        ?string $serverId = null
     ): OperationResponse {
 
         $options = [
@@ -73,8 +71,6 @@ public function create(
 
     /**
      * Update a cron task.
-     *
-     * @param string|null $serverId
      */
     public function update(
         string $environmentUuid,
@@ -82,7 +78,7 @@ public function update(
         string $command,
         string $frequency,
         string $label,
-        string $serverId = null
+        ?string $serverId = null
     ): OperationResponse {
 
         $options = [
diff --git a/src/Endpoints/Roles.php b/src/Endpoints/Roles.php
index 334c403a..5dbb1bcb 100644
--- a/src/Endpoints/Roles.php
+++ b/src/Endpoints/Roles.php
@@ -39,13 +39,12 @@ public function get(string $roleUuid): RoleResponse
      * Create a new role.
      *
      * @param array<string> $permissions
-     * @param string|null $description
      */
     public function create(
         string $organizationUuid,
         string $name,
         array $permissions,
-        string $description = null
+        ?string $description = null
     ): OperationResponse {
         $options = [
             'json' => [
diff --git a/src/Endpoints/SslCertificates.php b/src/Endpoints/SslCertificates.php
index 3667d1f2..6e4a3557 100644
--- a/src/Endpoints/SslCertificates.php
+++ b/src/Endpoints/SslCertificates.php
@@ -46,17 +46,14 @@ public function get(string $environmentUuid, int $certificateId): SslCertificate
 
     /**
      * Install an SSL certificate.
-     *
-     * @param string|null $ca
-     * @param int|null $csr
      */
     public function create(
         string $envUuid,
         string $label,
         string $cert,
         string $key,
-        string $ca = null,
-        int $csr = null,
+        ?string $ca = null,
+        ?int $csr = null,
         bool $legacy = false
     ): OperationResponse {
 
diff --git a/src/Exception/ApiErrorException.php b/src/Exception/ApiErrorException.php
index 32bdbdc9..367d9ab3 100644
--- a/src/Exception/ApiErrorException.php
+++ b/src/Exception/ApiErrorException.php
@@ -16,7 +16,7 @@ class ApiErrorException extends Exception
     /**
      * ApiErrorException Constructor.
      */
-    public function __construct(object $response_body, string $message = "", int $code = 0, Exception $previous = null)
+    public function __construct(object $response_body, string $message = "", int $code = 0, ?Exception $previous = null)
     {
         parent::__construct($message, $code, $previous);