Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Array Unique wrong validation for nullable values #2498

Open
wallace-sf opened this issue Jun 28, 2024 · 0 comments
Open

fix: Array Unique wrong validation for nullable values #2498

wallace-sf opened this issue Jun 28, 2024 · 0 comments
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.

Comments

@wallace-sf
Copy link

wallace-sf commented Jun 28, 2024

Description

Hey guys. I was trying to validate some data and I found a different behavior from the decorator ArrayUnique. According to the docs, If null or undefined is given then this function returns false., but this is not what is happening. The function returns true.

Minimal code-snippet showcasing the problem

Click here for Sandbox

The code is in the example.ts file in the src directory.

Expected behavior

The validation should not return any errors.

Actual behavior

The ArrayUnique decorator is not validating null or undefined duplicated values. These values should be ignored and the function should return false, but it is returning true.

@wallace-sf wallace-sf added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.
Development

Successfully merging a pull request may close this issue.

1 participant