Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature request] add missing properties to WorkflowCall trigger #614

Open
benkeil opened this issue Jan 11, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@benkeil
Copy link
Contributor

benkeil commented Jan 11, 2023

What feature do you need?

WorkflowCall should have the properties inputs, outputs and secrets, see GitHub documentation

Do you have an example usage?

like WorkflowDispatch

WorkflowCall(
  inputs = mapOf(
    "foo" to WorkflowCall.Input(
      "description",
      required = true,
      WorkflowDispatch.Type.String
    )
  ),
  secrets = mapOf(
    "bar" to WorkflowCall.Secret(
      "description",
      required = true,
    )
  )
)

Is there a workaround for not having this feature? If yes, please describe it.

use _customArguments

@benkeil benkeil added the enhancement New feature or request label Jan 11, 2023
@benkeil
Copy link
Contributor Author

benkeil commented Jan 12, 2023

Should inputs also be part of Contexts?

@krzema12
Copy link
Member

For each item from the GitHub contexts, I'm trying to figure out if it would be good to add specialized support for it, or just map it as is. E.g. for inputs, I'd like them to be defined on the workflow level in such way that allows accessing them from within the workflow in a type-safe way. Similarly with outputs, not sure what about secrets. If you have capacity, feel free to propose a change, then we can discuss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants