Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt rethinkdbdash definitions #11

Closed
marshall007 opened this issue Jun 10, 2017 · 5 comments
Closed

Adopt rethinkdbdash definitions #11

marshall007 opened this issue Jun 10, 2017 · 5 comments

Comments

@marshall007
Copy link

@blakeembrey I think I have finally accomplished what you were getting at in our previous discussion (#8). I have the repo up here: https://github.com/marshall007/npm-rethinkdbdash.

Apologies again for copying the definitions into that DefinitelyTyped PR, I just didn't understand enough about how all this works at the time to appreciate what the goals are here.

@blakeembrey @niieani I hope you guys will consider migrating my repo to the @types org and publish them to NPM.

Cheers!

@blakeembrey
Copy link
Contributor

Nice work! You're welcome to move the repo to @types. Let me know add you so you can move it 😄

@marshall007
Copy link
Author

@blakeembrey ok sounds good, yea I'm happy to move it over.

@marshall007
Copy link
Author

@blakeembrey I have transferred the repo: https://github.com/types/npm-rethinkdbdash

Can you walk me through the next steps? I don't think I have the ability to enable travis or greenkeeper per the guidelines. I imagine we'll also need a PR to the registry repo as well?

@unional
Copy link
Contributor

unional commented Jun 12, 2017

I'll rename the repo to types/rethinkdbdash?

Yes, a PR to registry. But let's get the travis up first.

@blakeembrey
Copy link
Contributor

I imagine we'll also need a PR to the registry repo as well?

Yep, that would be great.

@unional We can definitely start doing that overall. This is related to a greater discussion for all @types though to align with NPM @types. I'm happy to do that, I'll just need to move the guidelines to @typings for now and update the guidelines going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants