-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scalafmt-core to 3.8.3 #4640
Conversation
Executed command: scalafmt --non-interactive
@@ -41,7 +41,7 @@ class ShortAlgebra extends CommutativeRing[Short] with Serializable { | |||
def one: Short = 1 | |||
|
|||
def plus(x: Short, y: Short): Short = (x + y).toShort | |||
def negate(x: Short): Short = (-x).toShort | |||
def negate(x: Short): Short = -x.toShort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, new formatting breaks down this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞
Hmm, looks like the update breaks compilation:
|
@danicheg you were the first :) |
Seems to be already addressed in scalafmt: |
I feel we should skip this update and wait for the next one. |
Closing because of scalameta/scalafmt#4116. |
About this PR
📦 Updates org.scalameta:scalafmt-core from
3.8.2
to3.8.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: