Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.8.3 #4640

Closed
wants to merge 3 commits into from

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

📦 Updates org.scalameta:scalafmt-core from 3.8.2 to 3.8.3

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:3

@@ -41,7 +41,7 @@ class ShortAlgebra extends CommutativeRing[Short] with Serializable {
def one: Short = 1

def plus(x: Short, y: Short): Short = (x + y).toShort
def negate(x: Short): Short = (-x).toShort
def negate(x: Short): Short = -x.toShort
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, new formatting breaks down this

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@satorg
Copy link
Contributor

satorg commented Jul 26, 2024

Hmm, looks like the update breaks compilation:

[error] /home/runner/work/cats/cats/kernel/src/main/scala/cats/kernel/instances/ByteInstances.scala:34:32: type mismatch;
[error]  found   : Int
[error]  required: Byte
[error]   def inverse(x: Byte): Byte = -x.toByte
[error]                                ^
[error] /home/runner/work/cats/cats/kernel/src/main/scala/cats/kernel/instances/ShortInstances.scala:[33](https://github.com/typelevel/cats/actions/runs/10093785783/job/27910246153?pr=4640#step:10:34):34: type mismatch;
[error]  found   : Int
[error]  required: Short
[error]   def inverse(x: Short): Short = -x.toShort
[error]                                  ^

@satorg
Copy link
Contributor

satorg commented Jul 26, 2024

@danicheg you were the first :)

@mzuehlke
Copy link
Contributor

mzuehlke commented Jul 26, 2024

Seems to be already addressed in scalafmt:

@satorg
Copy link
Contributor

satorg commented Jul 26, 2024

I feel we should skip this update and wait for the next one.

@satorg
Copy link
Contributor

satorg commented Jul 26, 2024

Closing because of scalameta/scalafmt#4116.

@satorg satorg closed this Jul 26, 2024
@satorg satorg deleted the update/scalafmt-core-3.8.3 branch July 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants