Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sponsors.js should probably be deduplicated #4663

Open
jducoeur opened this issue Oct 8, 2024 · 1 comment
Open

sponsors.js should probably be deduplicated #4663

jducoeur opened this issue Oct 8, 2024 · 1 comment
Labels
bug documentation good first issue Issues that are easier to take on for first time contributors scope: small

Comments

@jducoeur
Copy link
Member

jducoeur commented Oct 8, 2024

docs/js/sponsors.js drives the list of financial contributors on the sponsors page. This is driven mainly by loading the list of sponsors from OpenCollective.

We recently fixed a bug that was omitting sponsors (one of the Gold-tier sponsors pointed it out), but that revealed a different bug: we're now showing duplicate entries for some organizations and people. (Including myself.)

I suspect that what's going on is that the OC GraphQL query is returning every "membership" -- each distinct tuple of (member, tier) -- rather than the members themselves. So if an organization has changed its subscription, or someone has gone from ad-hoc to recurring contributor, they have multiple entries and we show it multiple times.

The current situation isn't tragic, but I'd recommend that we deduplicate this list, and only show the highest tier that each member occupies.

@jducoeur jducoeur added bug documentation scope: small good first issue Issues that are easier to take on for first time contributors labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation good first issue Issues that are easier to take on for first time contributors scope: small
Projects
None yet
Development

No branches or pull requests

2 participants
@jducoeur and others