Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalatest deadlocks very easily #145

Open
m50d opened this issue Mar 31, 2021 · 5 comments
Open

Scalatest deadlocks very easily #145

m50d opened this issue Mar 31, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@m50d
Copy link

m50d commented Mar 31, 2021

Minimal example: https://scastie.scala-lang.org/NU86Wy4kTTukZzaSTUM2VA
I think this is because AsyncIOSpec passes scalatest's executionContext which is serialExecutionContext and not really suitable for general-purpose use.

@djspiewak
Copy link
Member

Hmm, what's the ideal solution here? Is it better to just override ScalaTest's ExecutionContext? I don't actually use ScalaTest so I can't speak to its idiomatic usage.

@djspiewak djspiewak added the bug Something isn't working label May 24, 2021
@m50d
Copy link
Author

m50d commented May 25, 2021

Overriding the executionContext seems to work. I avoid ScalaTest as much as possible myself TBH, I don't know what's considered idiomatic there.

@djspiewak
Copy link
Member

What should we override it with? The IORuntime default EC?

@m50d
Copy link
Author

m50d commented May 25, 2021

Sounds reasonable to me.

@djspiewak
Copy link
Member

djspiewak commented May 25, 2021

Alrighty, it's duly on my todo list (PRs welcome if someone gets to it first!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants