Skip to content

Latest commit

 

History

History
151 lines (101 loc) · 7.19 KB

CONTRIBUTING.md

File metadata and controls

151 lines (101 loc) · 7.19 KB
Raw

Contribution Guide

This project is open source and community driven. As such we encourage code contributions of all kinds. Some areas you can contribute in:

  1. Improve the stubs
  2. Sync stubs with the latest version of Django
  3. Improve plugin code and extend its capabilities
  4. Write tests
  5. Update dependencies
  6. Fix and remove things from our scripts/stubtest/allowlist_todo.txt

Tutorials

If you want to start working on this project, you will need to get familiar with python typings. The Mypy documentation offers an excellent resource for this, as well as the python official documentation:

Additionally, the following resources might be useful:

Dev setup

Repository Setup

As a first step you will need to fork this repository and clone your fork locally. In order to be able to continuously sync your fork with the origin repository's master branch, you will need to set up an upstream master. To do so follow this official github guide.

Dependency Setup

After your repository is setup you will then need to create and activate a git ignored virtual env, e.g.:

python3 -m venv .venv
source .venv/bin/activate

Then install the dev requirements:

SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements.txt

Finally, install the pre-commit hooks:

pre-commit install

Testing and Linting

We use mypy, pytest, ruff, and black for quality control. ruff and black are executed using pre-commit when you make a commit. To ensure there are not formatting or typing issues in the entire repository you can run:

pre-commit run --all-files

NOTE: This command will not only lint but also modify files - so make sure to commit whatever changes you've made before hand. You can also run pre-commit per file or for a specific path, simply replace "--all-files" with a target (see this guide for more info).

To execute the unit tests, simply run:

pytest

If you get some unexpected results or want to be sure that tests run is not affected by previous one, remove mypy cache:

rm -r .mypy_cache

Testing stubs with stubtest

Run bash ./scripts/stubtest.sh to test that stubs and sources are in-line.

We have two special files to allow errors:

  1. scripts/stubtest/allowlist.txt where we store things that we really don't care about: hacks, django internal utility modules, things that are handled by our plugin, things that are not representable by type system, etc
  2. scripts/stubtest/allowlist_todo.txt where we store all errors there are right now. Basically, this is a TODO list: we need to work through this list and fix things (or move entries to real allowlist.txt). In the end, ideally we can remove this file

You might also want to disable incremental mode while working on stubtest changes. This mode leads to several known problems (stubs do not show up or have strange errors).

Important: right now we only run stubtest on Python 3.12 (because it is the latest released version at the moment), any other versions might generate different outputs. Any work to create per-version allowlists is welcome.

Submission Guidelines

The workflow for contributions is fairly simple:

  1. Fork and set up the repository as in the previous step.
  2. Create a local branch.
  3. Make whatever changes you want to contribute.
  4. Ensure your contribution passes linting and tests.
  5. Make a pull request with an adequate description.

Generics

As Django uses a lot of the more dynamic features of Python (i.e. metaobjects), statically typing it requires heavy use of generics. Unfortunately, the syntax for generics is also valid Python syntax. For instance, the statement class SomeClass(SuperType[int]) implicitly translates to class SomeClass(SuperType.__class_getitem__(int)). If SuperType doesn't define the __class_getitem__ method, this causes a runtime error, even if the code passes type checking.

When adding a new generic class, or changing an existing class to use generics, run a quick test to see if it causes a runtime error. If it does, please add the new generic class to the _need_generic list in the django_stubs_ext.patch module.

Private attributes

We only add hints for private attributes when it has some demonstrated real-world use case. That means from a third-party package or some well described snippet for a project. This rule helps us avoid tying in too closely to Django’s undocumented internals.

Releasing django-stubs

  1. Open a pull request that updates setup.py, ext/setup.py and README.md (anyone can open this PR, not just maintainers):

    • Version number major.minor.patch is formed as follows:

      major.minor version must match newest supported Django release.

      patch is sequentially increasing for each stubs release. Reset to 0 if major.minor was updated.

    • Update the version= value within setup(...) call in both setup.py files. The versions must be in sync.

    • Update django-stubs-ext>= dependency in root setup.py to the same version number.

    • Add a new row at the top of 'Version compatibility' table in README.md.

    • Use pull request title "Version x.y.z release" by convention.

    • Add the correct classifiers to setup.py if support is added for a new Python or Django version

  2. Ensure the CI succeeds. A maintainer must merge this PR. If it's just a version bump, no need to wait for a second maintainer's approval.

  3. A maintainer must сreate a new GitHub release:

    • Under "Choose a tag" enter the new version number. Do not use v prefix.
    • Click "Generate release notes".
    • Look for merged PRs with the 'release notes reminder' label and move them to a separate section at the top, so that they stand out. Remove the label from PRs.
    • Delete all release notes lines containing by @pre-commit-ci or by @dependabot, as these are irrelevant for our users.

  4. Once you feel brave enough, click "Publish release".

  5. Check that the release workflow succeeds.