Fix jackson sbt assembly duplicate depends issue #867
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## develop #867 +/- ##
===========================================
- Coverage 77.45% 77.43% -0.03%
===========================================
Files 814 814
Lines 24111 24111
Branches 1597 1599 +2
===========================================
- Hits 18676 18671 -5
- Misses 5435 5440 +5
Continue to review full report at Codecov.
|
|
Hi @alikemalocalan, thanks for the submission. Sorry that I missed it earlier this week. I'm catching up on the details now. |
There was a problem hiding this comment.
The other projects contain a dependency on jackson for perhaps not an obvious reason. For our open source projects like Finagle (which includes Finatra, Util, Scrooge, and TwitterServer), there are two build systems. One of which we use externally, sbt, while the other we use internally, pants -> eventually bazel. With that said, pants has stricter rules on the use of transitive dependencies, especially when types are used or exported from that dependency. So it's easiest for maintenance and management if our dependencies for our sbt projects match those closely with the ones for pants. That's why it might not be obvious why some of these projects contain a dependency on jackson.
I'm curious as to how changing things in this way fixes your issue.
| @@ -497,8 +497,7 @@ lazy val finagleException = Project( | |||
| name := "finagle-exception", | |||
| libraryDependencies ++= Seq( | |||
| util("codec") | |||
| ) ++ scroogeLibs, | |||
| libraryDependencies ++= jacksonLibs | |||
| ) ++ scroogeLibs | |||
There was a problem hiding this comment.
finagle-exception uses jackson directly, so it really should have a dependency on jackson.
| @@ -520,7 +519,6 @@ lazy val finagleServersets = Project( | |||
| ), | |||
| "commons-lang" % "commons-lang" % "2.6" | |||
| ), | |||
| libraryDependencies ++= jacksonLibs, | |||
There was a problem hiding this comment.
finagle-serversets does too, so it should too.
| @@ -720,7 +716,7 @@ lazy val finagleMySQL = Project( | |||
| util("stats"), | |||
| caffeineLib, | |||
| jsr305Lib | |||
| ) ++ jacksonLibs, | |||
| ), | |||
|
@alikemalocalan, are you interested in addressing Ryan's feedback? |
|
hi @bryce-anderson , i understood explanation of @ryanoneill , my solution isn't useful for like this project. Maybe next years , if you will find more simple sbt sub-module solution, i can help you :D |
Problem
Fixes #855
Explain the context and why you're making that change. What is the
problem you're trying to solve? In some cases there is not a problem
and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes
this section is unnecessary because it is self-explanatory based on
the solution.