Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on just one XML library #41

Open
exarkun opened this issue Jan 19, 2017 · 1 comment
Open

Rely on just one XML library #41

exarkun opened this issue Jan 19, 2017 · 1 comment

Comments

@exarkun
Copy link
Member

exarkun commented Jan 19, 2017

Currently txAWS uses both lxml and the stdlib xml libraries. This is confusing and results in duplication of efforts. Pick one and just use it everywhere.

@mithrandi
Copy link
Contributor

Historically, lxml on PyPy has posed some difficulties, but as things currently stand, lxml works just fine on PyPy, so I suggest we pick that. (Among other things, lxml's XPath support is quite useful in many scenarios, although I don't think it's being used anywhere yet)

Mixing uses of the stdlib ElementTree and lxml.etree is probably going to result in somebody trying to pass objects from the one library into the other library at some point, which is going to result in very confusing failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants