Add Array#at polyfill
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HosokawaR
force-pushed
the
fix/array-at-unsupport-error
branch
from
ff26f89
to
1ada30b
Compare
hayato24s
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716
背景
一部の環境で
Array#atが使えないことによる検索画面のエラーが出ている。そこそこ影響範囲が大きく Sentry によると過去 2 週間で 50 ユーザ程度が影響を受けていそう。
Ref: #716
変更
Array#atを古いブラウザでも使用するため Polyfill を入れた。そもそも今
Array#atが使用されている箇所を書き直す案も考えたが、今後もArray#atが使用される可能性がある、開発体験としてArray#atのほうがいい、という理由から Polyfill を入れることにした。動作確認
Array#atが使えない環境を用意することが難しかったので、擬似的に再現した。Array#atを使えない環境を再現index.htmlの<head>内<script>にてdelete Array.prototype.atをして、その状態で講義検索を実行。Array#atが使えなくなっていることを確認した。その状態で Polyfill を差し込む
その後この PR の差分を適応。この状態では
Array#atが正常に使えることを確認。よって Polyfill がちゃんと動いていそう