Prevent tests from ever connecting to a couch instance...

[the-t-in-rtf]

In working on recent tests, I have noticed that nock is not entirely preventing connections to the local couch instance, which is still required to run many tests.

I would propose one of the following:

1. migrating to using pouchdb for testing. I have had good results using that to replace couch in other unit tests, as long as the views used are not too complex (ours aren't in this case).
2. firewalling nock by disabling connections using disableNetConnect() and fixing any tests that break (see below).

For the firewalling option, I tried using code like the following:

 nock.disableNetConnect();
 nock.enableNetConnect("(localhost|127.0.0.1):(?!5984).*");

In doing so, I discovered that nock appears to be shared across tests, which is hugely dangerous. I will file a separate bug on that.

[warrensplayer]

I am all for calling nock.disableNetConnect(); to prevent nock from calling out to a real endpoint. It is definitely best practice for unit tests to not rely on external endpoints.

I don't think it is worth changing all the tests to use pouchdb unless there are some other benefits that it provides over nock.

[warrensplayer]

@the-t-in-rtf Can you paste in the output from the tests before you added that nock.disableNetConnect()? I want to make sure I can reproduce your issue. Thanks!

[the-t-in-rtf]

@warrensplayer, check out this branch:

https://github.com/the-t-in-rtf/express-couchUser/tree/nock-disable-net

With a single line change to one test I can break all tests. I disabled networking connections in the signup tests, and the rest of the tests (signin, delete) stop working.