fix: Use xz compression to restore Debian stable support #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default compression on deb packages seems to have changed to zstd. Unfortunately, Debian does not support zstd (yet), so this specifies a friendlier format. Fixes twilio#482
kridai
reviewed
Feb 17, 2023
.github/scripts/pack-debian-apt.js
Outdated
| @@ -81,7 +81,8 @@ PATH=$PATH:$PWD/bin eval $(PATH=$PATH:$PWD/bin node -p "require('./package').scr | |||
| await qq.chmod([workspace, 'usr/lib', config.dirname, 'bin', config.bin], 0o755); | |||
| await qq.chmod([workspace, 'DEBIAN/postinst'], 0o755); | |||
| await qq.x(`ln -s "../lib/${config.dirname}/bin/${config.bin}" "${workspace}/usr/bin/${pjson.oclif.bin}"`); | |||
| await qq.x(`dpkg --build "${workspace}" "${qq.join(dist, debArch(arch), `${versionedDebBase}.deb`)}"`); | |||
| // Use xz compression until Debian supports zstd (see issue #482) | |||
| await qq.x(`dpkg --build --compression=xz "${workspace}" "${qq.join(dist, debArch(arch), `${versionedDebBase}.deb`)}"`); | |||
There was a problem hiding this comment.
--compression does not seems to be a valid flag in dpkg, could you confirm that this command works.
There was a problem hiding this comment.
Thanks for taking a look! You're right, that flag isn't valid. I saw it on a man page somewhere, but I must have been looking at the wrong command. I apologize for that.
I just pushed a commit that should fix it. As I said in the OP I don't really have a good environment to test this, but my understanding from here and here is that this should do the trick.
|
I am testing this fix. Will update soon. |
sbansla
requested changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default compression on deb packages seems to have changed to zstd. Unfortunately, Debian does not support zstd (yet), so this specifies a friendlier format.
Note that I don't know a good way to test this at the moment. I'm open to suggestions though.
Fixes #482
Checklist