Avoid boolean blindness with choice

[brandonchinn178]

Broken off from #1097 (comment)

Broke off some easy places. Not urgent

Pros:

• Prevents boolean blindness when constructing literals
• Prevents mixing up two boolean values

Cons:

• Casting to/from bool is a bit tedious. See Update doc, add isTrue/isFalse mboes/choice#6

[amesgen]

Looks great, thanks for following up on that comment 😄

There are additional places (eg replacing IsApplicand) that could be changed, but this can happen incrementally.

I like mboes/choice#6, but I would also be fine to merge this now.

[brandonchinn178]

@amesgen Do you know how to update the Nix config to fetch the new choice version that was released to Hackage?

[mrkkrp]

Very nice! I left one minor comment.

[mrkkrp]

Can you also rebase?

[amesgen]

@amesgen Do you know how to update the Nix config to fetch the new choice version that was released to Hackage?

Pushed a corresponding commit 👍 (nix flake update haskellNix)

[brandonchinn178]

@amesgen Thanks. FWIW I don't have Nix installed; it's a bit difficult to make that change to make that change as a non-Nix contributor...