Fix interaction of operators starting with # and UnboxedSums
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
commented
Sep 1, 2023
| handleUnboxedSumsAndHashInteraction | ||
| | unboxedSums, | ||
| -- Qualified names do not start wth a `#`. | ||
| Unqual (occNameString -> '#' : _) <- x = |
There was a problem hiding this comment.
I am not 100% sure if the Orig or Exact constructors of RdrName could ever be relevant here 🤔
Merged
amesgen
force-pushed
the
amesgen/issue-1062
branch
from
8b446c9
to
d5edd8f
Compare
mrkkrp
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1062
From https://downloads.haskell.org/ghc/9.6.2/docs/users_guide/exts/primitives.html:
It turns that this is already the case for
UnboxedSums(which is implied byUnboxedTuples).