Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--pyc is too dangerous #23

Open
tusharsadhwani opened this issue Jun 24, 2024 · 5 comments
Open

--pyc is too dangerous #23

tusharsadhwani opened this issue Jun 24, 2024 · 5 comments

Comments

@tusharsadhwani
Copy link
Owner

Right now, it destroys the input directory to create the package. Bad idea.

Let's make it copy the directory to /tmp and destroy the copy instead.

Maybe pycify should have been like that in the first place. Doing this change in pycify may also make sense.

@tusharsadhwani
Copy link
Owner Author

tusharsadhwani commented Jun 24, 2024

@NobleMathews would you like to approach this?

At first I was thinking that pycify should use an --inplace flag that would be mandatory if --out-dir is not specified. But that would break backwards compatibility. Though I suppose that might be fine.

@NobleMathews
Copy link
Contributor

Sure, Doesn't pycify have an output dir argument for that?

So there shouldn't be a need to update pycify just point it to a temp dir like you suggested

@NobleMathews
Copy link
Contributor

Ah didn't see your edit will check

@tusharsadhwani
Copy link
Owner Author

outdir arg will still delete the original files iirc.

@tusharsadhwani
Copy link
Owner Author

actually, pycify is fine. let's just change packaged to make a copy of the input directory in /tmp and then run pycify there then use that directory as the input directory instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants