Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded replicas #24

Open
vicary opened this issue Dec 19, 2024 · 1 comment · May be fixed by #25
Open

Support embedded replicas #24

vicary opened this issue Dec 19, 2024 · 1 comment · May be fixed by #25

Comments

@vicary
Copy link

vicary commented Dec 19, 2024

Summary

  1. The default import of @libsql/client here resolves to web.js, which contains no support of the file: protocol.
  2. The requirement of manual closing when using the client option is unrealistic for most use cases, without Kysely exposing some kind of "on destroy" callback.

Suggested Solution

  1. Add a new option createClient as a callback
@vicary vicary linked a pull request Dec 19, 2024 that will close this issue
@vicary
Copy link
Author

vicary commented Dec 19, 2024

Turns out it's unnecessary because

  1. web.js is imported because of Deno, Node is fine.
  2. Although client still makes no sense for manual closing, it should be a PR for @libsql/client instead.
  3. kysely.destroy() should not be optional because users have no reason to call it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant