Add ability to reload cert and key from disk. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables frequent rotation of certificates
What and why?
This change will reload certificate + key on the listener when the files change on-disk.
Allows use of cert-manager and avoiding having hardcoded infinite TTL certificates.
Testing Steps
Started controller:
delete the TLS secret, let cert-manager recreate it, and try to recreate injected Pod:
A minute later, injector controller is able to handle requests again (without restarting):
Reviewers
Required reviewers:
@byxorna
Request reviews from other people you want to review this PR in the "Reviewers" section on the right.