Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPF: tumblrmart_accessories only returns the blue-checkmark and not other badges #114

Open
fukou opened this issue Aug 2, 2023 · 2 comments

Comments

@fukou
Copy link

fukou commented Aug 2, 2023

Hello, I am not sure if this is the place to ask so apologize in advance if it's not.

Bug description

I'm currently building a theme using the {NPF} variable to get the JSON representation of posts and display custom badges on reblog trails. However, it seems I have encountered a bug.

In the tumblrmart_accessories, only the blue-checkmark of product_group is showing up, and the rainbow checkmarks and other badges are not appearing at all—which returns an empty object

image

I have a test blog where I reblogged a bunch of posts that have custom badges for some of the reblog trails, which you can find here: https://fukuo-test.tumblr.com/tagged/badges (reference on the blog view: https://tumblr.com/fukuo-test/tagged/badges).
I have also printed the console.log of each trail.blog.tumblrmart_accessories on that blog for clarity.

Thank you very much.

Expected Behaviour

To display the other badges, apart from the blue checkmark, under the tumblrmart_accessories.

@cyle
Copy link
Member

cyle commented Aug 2, 2023

Hello! Yeah, this is a totally valid place to report this issue. At first glance, it looks like we're still limiting access to those values to our official clients only, they haven't made it out to third party API integrations yet. We haven't even documented tumblrmart_accessories in the API docs or NPF spec yet for that reason. So for now, I suggest keeping an eye on this repo for when we do update the docs with that info, but there is usually a lag time between when something is released officially and when (and if) it becomes available to public API consumers.

@fukou
Copy link
Author

fukou commented Aug 4, 2023

Ah, that makes sense! You're right, tumblrmart_accessories has not been documented yet, so it's expected that the access is limited or not public yet 😅

Thanks a lot for the answer, I'm looking forward to it! And I will definitely keep an eye on this repo from time to time! ✨
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants