Performance in beta with the new Dominos

[boomboo]

Seems like the newest version of Dominos causes some performance regression with tullacc.
This is with the previous beta

this one is with the new version

To be more specific, old refers to 9.0 beta and new to 9.0 beta1 on wowinterface.

[Tuller]

Can you comment out the code in https://github.com/tullamods/Dominos/blob/de9f380e031b6daf9ac175d8aff98de6de095ae3/Dominos/bars/actionButtonMixin.lua#L88

And see what happens?

[boomboo]

I comented out the functionality, no significant changes or none at all. (to be clear the issue isn't solved by commenting that section)

[boomboo]

I'm not sure why or how but version 4 fixed the issue, I retested with v3 and it was still there but v4 fixes it.

[Tuller]

Dominos defers action button creation a bit in beta 4, do you happen to shrink your unused action bars?

[boomboo]

Yes, I usually shrink (1x1) and hide the ones I don't use.

[Tuller]

Yeah that’ll cause those buttons to never be created by dominos (provided they didn’t exist already) and is likely the cause of your CPU usage reduction

[boomboo]

Oh so you mean the reduction is incidental in that whatever caused the increase is still there however with v4 there are less buttons to work on?

[Tuller]

I would suspect that the per button CPU usage is about the same between the versions. The only difference was Dominos creating/hooking all 120 action buttons even if you'd shrunk your bars