feat : 그룹 삭제 기능 추가 #405 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaBaljaintheroom
approved these changes
May 15, 2024
Comment on lines
+93
to
+95
| private void checkGroupOwnership(Long memberId, List<MemberGroup> groupMembers) { | ||
| final boolean isGroupOwner = groupMembers.stream() | ||
| .anyMatch(mg -> mg.getMember().getId().equals(memberId) && mg.getIsOwner()); |
There was a problem hiding this comment.
93번째 줄부터 매개변수에 final 붙여야겠당
...archive/core/domain/group_member/repository/groupInviteRepository/GroupInviteRepository.java
Show resolved
Hide resolved
Comment on lines
+41
to
+42
| class GroupCommandServiceTest { | ||
|
|
There was a problem hiding this comment.
여기서 notOwnerGroupMember() 메서드들 같은걸 Fixture에 안넣고 여기에 넣은 이유가 있어? 이건 걍 궁금
There was a problem hiding this comment.
이거 옮길께 나도 모르게 그냥 테스트에 작성해버림
Comment on lines
+24
to
+39
| public static Member memberWithMemberId(long memberId) { | ||
| try { | ||
| Member member = member((int) memberId); | ||
| setFieldValue(member, "id", memberId); | ||
| return member; | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| private static void setFieldValue(Object instance, String fieldName, Object value) | ||
| throws NoSuchFieldException, IllegalAccessException { | ||
| Field field = instance.getClass().getDeclaredField(fieldName); | ||
| field.setAccessible(true); | ||
| field.set(instance, value); | ||
| } |
There was a problem hiding this comment.
기존의 Fixture에서 Member를 만드는 방법을 사용안하고 이렇게 했을 때의 장점이 뭐야?
There was a problem hiding this comment.
이거 memberId 넣을 수 있는 생성자가 없어서 이렇게 한거 기존 Member를 테스트위해서 수정할 수 없어성
GaBaljaintheroom
approved these changes
May 15, 2024
Comment on lines
+24
to
+39
| public static Member memberWithMemberId(long memberId) { | ||
| try { | ||
| Member member = member((int) memberId); | ||
| setFieldValue(member, "id", memberId); | ||
| return member; | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| private static void setFieldValue(Object instance, String fieldName, Object value) | ||
| throws NoSuchFieldException, IllegalAccessException { | ||
| Field field = instance.getClass().getDeclaredField(fieldName); | ||
| field.setAccessible(true); | ||
| field.set(instance, value); | ||
| } |
...archive/core/domain/group_member/repository/groupInviteRepository/GroupInviteRepository.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 (Content)
링크 (Links)
기타 사항 (Etc)
1. 그룹이 존재해야 함.
2. 그룹 삭제를 요청한 사용자가 그룹장이여야 함.
3. 그룹에 그룹원이 존재하지 않아야 함.
4. 그룹에 그룹 캡슐이 존재하지 않아야 함.
5. 위의 4가지 조건을 만족하면 그룹 삭제
Merge 전 필요 작업 (Checklist before merge)
희망 리뷰 완료 일 (Expected due date)